Skip to contentSkip to conversation

sata_nv: handle SError status indication

PATCH Applied Robert Hancock 2 participants 2 messages Feb 12, 2007 – Feb 15, 2007 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sata_nv: handle SError status indication

ADMA-capable controllers provide a bit in the status register that appears to indicate that the controller detected an SError condition. Update sata_nv to detect this and trigger error handling in order to handle the fault.

ata/sata_nv.c renamed from ata/sata_nv.c.before_serror +0 -0
@@ -827,7 +827,8 @@ static irqreturn_t nv_adma_interrupt(int
			/* freeze if hotplugged or controller error */
			if (unlikely(status & (NV_ADMA_STAT_HOTPLUG |
					       NV_ADMA_STAT_HOTUNPLUG |
-					       NV_ADMA_STAT_TIMEOUT))) {
+					       NV_ADMA_STAT_TIMEOUT |
+					       NV_ADMA_STAT_SERROR))) {
				struct ata_eh_info *ehi = &ap->eh_info;

				ata_ehi_clear_desc(ehi);
@@ -841,6 +842,9 @@ static irqreturn_t nv_adma_interrupt(int
				} else if (status & NV_ADMA_STAT_HOTUNPLUG) {
					ata_ehi_hotplugged(ehi);
					ata_ehi_push_desc(ehi, ": hot unplug");
+				} else if (status & NV_ADMA_STAT_SERROR) {
+					/* let libata analyze SError and figure out the cause */
+					ata_ehi_push_desc(ehi, ": SError");
				}
				ata_port_freeze(ap);
				continue;
Applied
#1 lore raw
Quoted 5 lines · Robert Hancock

ADMA-capable controllers provide a bit in the status register that appears to indicate that the controller detected an SError condition. Update sata_nv to detect this and trigger error handling in order to handle the fault.

applied