Skip to contentSkip to conversation

: sch_hfsc: replace ASSERT macro by WARN_ON

NET_SCHED Applied Patrick McHardy 2 participants 2 messages Feb 13, 2007

Subsystems (3)
Networking Network drivers Traffic control (tc)
lore
Share & tools
lore

Patrick McHardy

author
#0 lore raw

[NET_SCHED]: sch_hfsc: replace ASSERT macro by WARN_ON

Signed-off-by Patrick McHardy <[email protected]>

---
commit ee0d5b5b1a2f81dabd5189c6ac960e7cab40d8ff
tree 6975f4ea578fb1e86f8d9c7607fa08ec3a8c841f
parent 6e1d9d04c4004361fb327abcbde74a20e8dca2ff
author Patrick McHardy <[email protected]> Tue, 13 Feb 2007 16:15:12 +0100 committer Patrick McHardy <[email protected]> Tue, 13 Feb 2007 16:15:12 +0100

 net/sched/sch_hfsc.c |   15 +--------------
 1 files changed, 1 insertions(+), 14 deletions(-)
net/sched/sch_hfsc.c +1 -14
index 135087d..396deb7 100644
@@ -71,8 +71,6 @@ #include <net/pkt_cls.h>
 #include <asm/system.h>
 #include <asm/div64.h>
 
-#define HFSC_DEBUG 1
-
 /*
  * kernel internal service curve representation:
  *   coordinates are given by 64 bit unsigned integers.

@@ -211,17 +209,6 @@ do {									\
 } while (0)
 #endif
 
-#if HFSC_DEBUG
-#define ASSERT(cond)							\
-do {									\
-	if (unlikely(!(cond)))						\
-		printk("assertion %s failed at %s:%i (%s)\n",		\
-		       #cond, __FILE__, __LINE__, __FUNCTION__);	\
-} while (0)
-#else
-#define ASSERT(cond)
-#endif /* HFSC_DEBUG */
-
 #define	HT_INFINITY	0xffffffffffffffffULL	/* infinite time value */
 
 

@@ -1492,7 +1479,7 @@ hfsc_schedule_watchdog(struct Qdisc *sch
 		if (next_time == 0 || next_time > q->root.cl_cfmin)
 			next_time = q->root.cl_cfmin;
 	}
-	ASSERT(next_time != 0);
+	WARN_ON(next_time == 0);
 	delay = next_time - cur_time;
 	delay = PSCHED_US2JIFFIE(delay);