Skip to contentSkip to conversation

ext3: fix ext3 block bitmap leakage

RFC PATCH In review Adrian Bunk 2 participants 3 messages Feb 20, 2007 – Feb 26, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Adrian Bunk

author
#1 lore raw

RFC PATCH 1/1 ext3: fix ext3 block bitmap leakage

Quoted 3 lines · Chuck Ebbert

This was dropped from 2.6.16-stable somehow:

http://lkml.org/lkml/2006/6/30/54

Thanks for forwarding it.

This patch didn't went in this form into Linus' tree, I'd therefore like to get an ACK from the ext3 maintainers (Cc'ed) before applying it.

Quoted 2 lines

Below is probably mangled by Thunderbird, you'll have to fetch it yourself if you want to merge it:

patch(1) has a nice -l option for applying such patches. :-)

Quoted 22 lines

From: Kirill Korotaev <>

This patch fixes ext3 block bitmap leakage, which leads to the following fsck messages on _healthy_ filesystem:
Block bitmap differences: -64159 -73707

All kernels up to 2.6.17 have this bug.

Found by
Vasily Averin <[email protected]> and Andrey Savochkin <[email protected]>
Test case triggered the issue was created by
Dmitry Monakhov <[email protected]>

Signed-off-by Vasiliy Averin <[email protected]>
Signed-off-by Andrey Savochkin <[email protected]>
Signed-off-by Kirill Korotaev <[email protected]>
CC Dmitry Monakhov <[email protected]>

fs/ext3/inode.c static int ext3_alloc_branch(handle_t *h · line 591

Quoted 7 lines
fs/ext3/inode.c renamed from fs/ext3/inode.c.e3crp +1 -0
@@ -585,6 +585,7 @@ static int ext3_alloc_branch(handle_t *h
 
  	branch[0].key = cpu_to_le32(parent);
  	if (parent) {
+		keys = 1;
  		for (n = 1; n < num; n++) {
  			struct buffer_head *bh;
  			/* Allocate the next block */

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
Quoted 10 lines · Adrian Bunk
Quoted 3 lines · Chuck Ebbert

This was dropped from 2.6.16-stable somehow:

http://lkml.org/lkml/2006/6/30/54

Thanks for forwarding it.

This patch didn't went in this form into Linus' tree, I'd therefore like to get an ACK from the ext3 maintainers (Cc'ed) before applying it.

Yep, ACK from me for 2.6.16-stable.

-Eric

author
#3 lore raw
Quoted 5 lines · Eric Sandeen
Quoted 4 lines · Adrian Bunk
Quoted 2 lines · Chuck Ebbert

This was dropped from 2.6.16-stable somehow:

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

http://lkml.org/lkml/2006/6/30/54

Thanks for forwarding it.

This patch didn't went in this form into Linus' tree, I'd therefore like to get an ACK from the ext3 maintainers (Cc'ed) before applying it.

Yep, ACK from me for 2.6.16-stable.

Thanks, I've applied it.

Quoted 1 line

-Eric

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed