Skip to contentSkip to conversation

forcedeth: fixed missing call in napi poll

PATCH In review Ayaz Abdulla 2 participants 2 messages Feb 20, 2007 – Feb 27, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 forcedeth: fixed missing call in napi poll

The napi poll routine was missing the call to the optimized rx process routine. This patch adds the missing call for the optimized path.

drivers/net/forcedeth.c +7 -3
@@ -3104,13 +3104,17 @@
 	struct fe_priv *np = netdev_priv(dev);
 	u8 __iomem *base = get_hwbase(dev);
 	unsigned long flags;
+	int retcode;
 
-	if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2)
+	if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2) {
 		pkts = nv_rx_process(dev, limit);
-	else
+		retcode = nv_alloc_rx(dev);
+	} else {
 		pkts = nv_rx_process_optimized(dev, limit);
+		retcode = nv_alloc_rx_optimized(dev);
+	}
 
-	if (nv_alloc_rx(dev)) {
+	if (retcode) {
 		spin_lock_irqsave(&np->lock, flags);
 		if (!np->in_shutdown)
 			mod_timer(&np->oom_kick, jiffies + OOM_REFILL);
#1 lore raw
Quoted 3 lines · Ayaz Abdulla

The napi poll routine was missing the call to the optimized rx process routine. This patch adds the missing call for the optimized path.

applied 1-3