Skip to contentSkip to conversation

EC init cleanup patches

DISCUSSION Alexey Starikovskiy 2 participants 2 messages Feb 21, 2007 – Feb 23, 2007 ACPI

lore
Share & tools
lore
#0 lore raw

Hi,
Here is the patch series to clean-up init of EC.

Please test, comment.

Thanks,
Alex

reviewer
#1 lore raw
Quoted 6 lines · Alexey Starikovskiy

Hi,
Here is the patch series to clean-up init of EC.

Please test, comment.

ACPI: EC: enable burst functionality in EC

seems to expose ec_burst_enable(), but nobody calls it -- so the patch has no functional change by itself, yes?

looks like some unrelated cleanups in that patch too.

anybody able to test this out on the samsung box
that had trouble with burst mode?

if we are going to cut over to enabling burst mode by default, surely we should have a boot-param so the user can set it to whatever works -- as well as a dmesg indicator so we can tell what is going on -- like we do for ec_intr=, yes?

thanks,
-Len

ps. in the patch and mbox format, please include
a Signed-off-by: line in addition to the From: line --
i have to remember to add these manually when they're
not included in what you sent to me, and technically nobody should be adding a signed-off-by line with somebody elses's name on it...