[Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

milosz danielewski

author

2007-03-04 11:20 UTC #0 lore raw

Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I cannot use it...

regards
milosz danielewski

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Holtmann

maintainer

2007-03-04 17:31 UTC #1 lore raw

Hi Milosz,

Quoted 3 lines

Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I cannot use it...

I think that is simply because nobody needed them before. Feel free to implement them and send a patch. However UUID32 is the most unused UUID type. In general you should either use UUID16 for well known profile and service identifiers or UUID128 for your own identifiers.

Regards

Marcel

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

milosz danielewski

author

2007-03-05 19:14 UTC #2 lore raw

Quoted 9 lines · Marcel Holtmann <marcel <at> holtmann.org> writes:

Hi Milosz,
Quoted 3 lines
Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I cannot use it...
I think that is simply because nobody needed them before. Feel free to implement them and send a patch.

As far, as I can see it's already implemented, just not exposed in header file.

Quoted 3 lines

However UUID32 is the most unused UUID
type. In general you should either use UUID16 for well known profile and service identifiers or UUID128 for your own identifiers.

I've started to implement jsr82. When I create java object representing UUID
it's most convenient to pass 16 byte array from native C to Java. So, when I iterate over service attributes, have to properly convert SDP_UUID32 to uuid128. That's why I need to use sdp_uuid32_to_uuid128 (which is already implemented and working). Only problem is ugly warning "implicit declaration".

milosz danielewski

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Holtmann

maintainer

2007-03-05 20:22 UTC #3 lore raw

Hi Milosz,

Quoted 13 lines

Quoted 6 lines
Quoted 3 lines
Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I cannot use it...
I think that is simply because nobody needed them before. Feel free to implement them and send a patch.
As far, as I can see it's already implemented, just not exposed in header file.
Quoted 3 lines
However UUID32 is the most unused UUID
type. In general you should either use UUID16 for well known profile and service identifiers or UUID128 for your own identifiers.

Quoted 5 lines

I've started to implement jsr82. When I create java object representing UUID
it's most convenient to pass 16 byte array from native C to Java. So, when I iterate over service attributes, have to properly convert SDP_UUID32 to uuid128. That's why I need to use sdp_uuid32_to_uuid128 (which is already implemented and working). Only problem is ugly warning "implicit declaration".

then send a patch to fix this. Sounds like a really simple bug.

Regards

Marcel

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

milosz danielewski

author

2007-03-05 19:44 UTC #4 lore raw

Quoted 2 lines · Marcel Holtmann

Quoted 1 line
As far, as I can see it's already implemented, just not exposed in header file.
then send a patch to fix this. Sounds like a really simple bug.

As I am newbie here, what's the policy of sending patches? Should I
send it to bluez-devel list, or directly to you or whatever?

milosz danielewski

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Holtmann

maintainer

2007-03-05 20:50 UTC #5 lore raw

Hi Milosz,

Quoted 5 lines

Quoted 2 lines
Quoted 1 line
As far, as I can see it's already implemented, just not exposed in header file.
then send a patch to fix this. Sounds like a really simple bug.
As I am newbie here, what's the policy of sending patches? Should I
send it to bluez-devel list, or directly to you or whatever?

create a unified diff with your changes against the latest CVS code and send it to the BlueZ developer mailing list.

Regards

Marcel

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

milosz danielewski

author

2007-03-05 20:50 UTC #6 lore raw

Quoted 7 lines · Marcel Holtmann

Hi Milosz,
Quoted 2 lines
As I am newbie here, what's the policy of sending patches? Should I
send it to bluez-devel list, or directly to you or whatever?
create a unified diff with your changes against the latest CVS code and send it to the BlueZ developer mailing list.

here it goes...

milosz danielewski

Index: sdp_lib.h
===================================================================
RCS file: /cvsroot/bluez/libs/include/sdp_lib.h,v
retrieving revision 1.29

sdp_lib.h +1 -0

diff -u -r1.29 sdp_lib.h
@@ -475,6 +475,7 @@
 int sdp_uuid128_cmp(const void *p1, const void *p2);
 uuid_t *sdp_uuid_to_uuid128(uuid_t *uuid);
 void sdp_uuid16_to_uuid128(uuid_t *uuid128, uuid_t *uuid16);
+void sdp_uuid32_to_uuid128(uuid_t *uuid128, uuid_t *uuid32);
 int sdp_uuid128_to_uuid(uuid_t *uuid);
 int sdp_uuid_to_proto(uuid_t *uuid);
 int sdp_uuid_extract(const uint8_t *buffer, uuid_t *uuid, int *scanned);

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Holtmann

maintainer

2007-03-05 21:55 UTC #7 lore raw

Hi Milosz,

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
As I am newbie here, what's the policy of sending patches? Should I
send it to bluez-devel list, or directly to you or whatever?
create a unified diff with your changes against the latest CVS code and send it to the BlueZ developer mailing list.
here it goes...

looks good to me. Patch has been applied and committed. Thanks.

Regards

Marcel

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Albert Huang

2007-03-04 20:47 UTC #8 lore raw

In reply to milosz danielewski

How about these?

uuid_t *sdp_uuid32_create(uuid_t *uuid, uint32_t data); uuid_t *sdp_uuid_to_uuid128(uuid_t *uuid);

Quoted 7 lines · milosz danielewski

Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I cannot use it...
regards
milosz danielewski

Quoted 10 lines

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel