Skip to contentSkip to conversation

PATCH: Fix VMI and COMPAT_VDSO for 2.6.21

DISCUSSION Zachary Amsden 2 participants 4 messages Mar 10, 2007 virtio core

lore
Share & tools
lore

Zachary Amsden

author
#0 lore raw

VMI is broken under COMPAT_VDSO, as Xen and other non hardware assisted hypervisors will be. I have been working on a fix for this which works for older glibcs that panic when the new relocatable VDSO is used. However, I believe at this time that the fix is going to be too radical to consider at this stage in the release of 2.6.21. We don't expect this config option to be turned on by vendors for new distributions, so at this point we are willing to drop support for it when VMI is compiled in, and work on a patch for 2.6.22 which more fully addresses the problem.

Please apply, thanks.

Zach

author
#1 lore raw
Quoted 3 lines · Zachary Amsden

VMI is broken under COMPAT_VDSO, as Xen and other non hardware assisted hypervisors will be. I have been working on a fix for this which works for older glibcs that panic when the new relocatable VDSO is used. However, I believe at this time that the fix is going to be too radical to consider at this stage in the release of 2.6.21. We don't expect this config option to be turned on by vendors for new distributions, so at this point we are willing to drop support for it when VMI is compiled in, and work on a patch for 2.6.22 which more fully addresses the problem.

Please apply, thanks.

I suppose it would be better if I attached the patch.

Zach

Signed-off-by Zachary Amsden <[email protected]>
arch/i386/Kconfig +1 -1
Index: linux-2.6.21/arch/i386/Kconfig
===================================================================
@@ -220,7 +220,7 @@ config PARAVIRT
 
 config VMI
 	bool "VMI Paravirt-ops support"
-	depends on PARAVIRT
+	depends on PARAVIRT && !COMPAT_VDSO
 	help
 	  VMI provides a paravirtualized interface to the VMware ESX server
 	  (it could be used by other hypervisors in theory too, but is not

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/virtualization

Acked-by
#2 lore raw
Quoted 11 lines · Zachary Amsden
Quoted 10 lines · Zachary Amsden

VMI is broken under COMPAT_VDSO, as Xen and other non hardware assisted hypervisors will be. I have been working on a fix for this which works for older glibcs that panic when the new relocatable VDSO is used. However, I believe at this time that the fix is going to be too radical to consider at this stage in the release of 2.6.21. We don't expect this config option to be turned on by vendors for new distributions, so at this point we are willing to drop support for it when VMI is compiled in, and work on a patch for 2.6.22 which more fully addresses the problem.

Quoted 1 line
Quoted 1 line

Please apply, thanks.

makes sense. We can do Jan's relocatable-COMPAT_VDSO thing in v2.6.22, but for v2.6.21 that's way too intrusive.

Acked-by Ingo Molnar <[email protected]>
Quoted 1 line

I suppose it would be better if I attached the patch.

it certainly helps ;-)

Ingo

author
#3 lore raw
Quoted 2 lines · Ingo Molnar

makes sense. We can do Jan's relocatable-COMPAT_VDSO thing in v2.6.22, but for v2.6.21 that's way too intrusive.

Agree. I think we can clean up some of the strange build magic though, by adding boot time ELF magic instead. We'll see which works out better.

Zach