Skip to contentSkip to conversation

sstfb: fix pixclock setting on Voodoo 1/2 cards

PATCH In review Antonino A. Daplas 2 participants 3 messages Mar 11, 2007 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 sstfb: fix pixclock setting on Voodoo 1/2 cards

From: Ondrej Zajicek <[email protected]>

Pixclock setting in sstfb didn't work with my Voodoo 2 card with ICS 5342 DAC (this DAC requires two consecutive writes to one of its registers to program pixclock - maybe first write merged with second).

This patch fixes bug with pixclock setting. It is against 2.6.21-rc1 .

---

 drivers/video/sstfb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/video/sstfb.c +1 -0
index 59cd1e7..62fa550 100644
@@ -257,6 +257,7 @@ static void __sst_dac_write(u8 __iomem *
 	r_dprintk("sst_dac_write(%#x, %#x)\n", reg, val);
 	reg &= 0x07;
 	__sst_write(vbase, DAC_DATA,(((u32)reg << 8)) | (u32)val);
+	__sst_wait_idle(vbase);
 }
 
 /* indexed access to ti/att dacs */

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

#2 lore raw
Quoted 1 line · Andrew Morton

These three patches look 2.6.21ish to me?

They are safe for 2.6.21.

Tony

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV