[Fwd: Re: [PATCH] NFS: Sign Extentions with Tru64 FSIDs.]

Steve Dickson

author

2007-03-16 15:36 UTC #0 lore raw

PATCH 1/1 NFS: Sign Extentions with Tru64 FSIDs.]

Any status or hope with these patches??

steved.

-------- Original Message --------
Subject: Re: [NFS] [PATCH] NFS: Sign Extentions with Tru64 FSIDs.
Date: Tue, 06 Mar 2007 16:42:56 -0500
From: Steve Dickson <[email protected]>
To: Trond Myklebust <[email protected]>, Neil Brown <[email protected]>
CC: '[email protected]' <[email protected]>
References: <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]>

Quoted 11 lines · Steve Dickson

Quoted 4 lines · Trond Myklebust
Quoted 2 lines · Peter Staubach
Or we could just punt and document that READDIRPLUS must be disabled on all Tru64 NFS servers if this problem is seen.
That would also be an option.
Assuming there is a way to turn off READDIRPLUS on the server side... I'll look into it... Or are you suggesting that we have a mount option to turn off READDIRPLUS on the client side? (Note: I believe other implementations have this mount option if that means anything)....

Not too surprising, there does not seem to be away to disable READDIRPLUS on the server side.... so... Since it was incredibly easy to disable READDIRPLUS from the client side... I went ahead came up and tested the attached patches...

Again, I believe there are other implementations, like Apple, that have this type of knob so in the end, this might be a good thing to have in general... It definitely helps with broken Tru64 servers... So please consider...

tia,

steved.

Added support to turn off the NFSv3 READDIRPLUS RPC.

Signed-off-by Steve Dickson <[email protected]>

----------------------------------------------

fs/nfs/super.c renamed from fs/nfs/super.c.orig +1 -0

@@ -291,6 +291,7 @@
 		{ NFS_MOUNT_NOAC, ",noac", "" },
 		{ NFS_MOUNT_NONLM, ",nolock", "" },
 		{ NFS_MOUNT_NOACL, ",noacl", "" },
+		{ NFS_MOUNT_NORDIRPLUS, ",nordirplus", "" },
 		{ 0, NULL, NULL }
 	};
 	const struct proc_nfs_info *nfs_infop;

fs/nfs/client.c renamed from fs/nfs/client.c.orig +2 -1

@@ -618,7 +618,8 @@
 	if (clp->cl_nfsversion == 3) {
 		if (server->namelen == 0 || server->namelen > NFS3_MAXNAMLEN)
 			server->namelen = NFS3_MAXNAMLEN;
-		server->caps |= NFS_CAP_READDIRPLUS;
+		if (!(data->flags & NFS_MOUNT_NORDIRPLUS))
+			server->caps |= NFS_CAP_READDIRPLUS;
 	} else {
 		if (server->namelen == 0 || server->namelen > NFS2_MAXNAMLEN)
 			server->namelen = NFS2_MAXNAMLEN;

include/linux/nfs_mount.h renamed from include/linux/nfs_mount.h.orig +1 -0

@@ -61,6 +61,7 @@
 #define NFS_MOUNT_NOACL		0x0800	/* 4 */
 #define NFS_MOUNT_STRICTLOCK	0x1000	/* reserved for NFSv4 */
 #define NFS_MOUNT_SECFLAVOUR	0x2000	/* 5 */
+#define NFS_MOUNT_NORDIRPLUS	0x4000	/* 5 */
 #define NFS_MOUNT_FLAGMASK	0xFFFF
 
 #endif

Adds the -o nordirplus mount option that will disable NFS clients from using the READDIRPLUS RPC.

Signed-off-by Steve Dickson <[email protected]>

------------------------------

utils/mount/nfs_mount.h renamed from utils/mount/nfs_mount.h.orig +1 -0

@@ -63,6 +63,7 @@
 #define NFS_MOUNT_BROKEN_SUID	0x0400	/* 4 */
 #define NFS_MOUNT_NOACL     0x0800  /* 4 */
 #define NFS_MOUNT_SECFLAVOUR	0x2000	/* 5 */
+#define NFS_MOUNT_NORDIRPLUS	0x4000	/* 5 */
 
 /* security pseudoflavors */

utils/mount/nfsmount.c renamed from utils/mount/nfsmount.c.orig +5 -0

@@ -788,6 +788,10 @@
 				data->flags &= ~NFS_MOUNT_NOACL;
 				if (!val)
 					data->flags |= NFS_MOUNT_NOACL;
+			} else if (!strcmp(opt, "rdirplus")) {
+				data->flags &= ~NFS_MOUNT_NORDIRPLUS;
+				if (!val)
+					data->flags |= NFS_MOUNT_NORDIRPLUS;
 #endif
 			} else {
 			bad_option:

@@ -975,6 +979,7 @@
 #endif
 #if NFS_MOUNT_VERSION >= 5
 	printf("sec = %u ", data.pseudoflavor);
+	printf("readdirplus = %d ", (data.flags & NFS_MOUNT_NORDIRPLUS) != 0);
 #endif
 	printf("\n");
 #endif

utils/mount/nfs.man renamed from utils/mount/nfs.man.orig +5 -0

@@ -272,6 +272,11 @@
 .I udp
 Mount the NFS filesystem using the UDP protocol.  This
 is the default.
+.TP 1.5i
+.I nordirplus
+Disables NFSv3 READDIRPLUS RPCs. Use this options when
+mounting servers that don't support or have broken
+READDIRPLUS implementations.
 .P
 All of the non-value options have corresponding nooption forms.
 For example, nointr means don't allow file operations to be

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Neil Brown

2007-03-18 23:43 UTC #1 lore raw

Quoted 1 line · On Friday March 16, [email protected] wrote:

Any status or hope with these patches??

I have no problem with the nfs-utils patch though obviously I won't commit it until Trond indicates that he will accept the fs/nfs patch.

NeilBrown

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Steve Dickson

author

2007-03-19 13:05 UTC #2 lore raw

Quoted 5 lines · Neil Brown

Quoted 1 line · On Friday March 16, [email protected] wrote:
Any status or hope with these patches??
I have no problem with the nfs-utils patch though obviously I won't commit it until Trond indicates that he will accept the fs/nfs patch.

Sounds reasonable...

Trond, any interest in the 4 line patch that would enable turning off readdirplus? The Tru64 folks would definitely appreciate it.. ;-)

steved.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Trond Myklebust

2007-03-19 15:09 UTC #3 lore raw

Quoted 5 lines · Steve Dickson

Quoted 3 lines · Neil Brown
Quoted 1 line · On Friday March 16, [email protected] wrote:
Any status or hope with these patches??

Quoted 7 lines

Quoted 2 lines
I have no problem with the nfs-utils patch though obviously I won't commit it until Trond indicates that he will accept the fs/nfs patch.
Sounds reasonable...
Trond, any interest in the 4 line patch that would enable turning off readdirplus? The Tru64 folks would definitely appreciate it.. ;-)

Fine by me, but I'm curious as to why you're not doing the same for NFSv4? If we're to support automatic negotiation of the NFS version some day, then we do need to have all NFSv3 options supported in NFSv4 and vice versa.

Cheers
Trond

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Steve Dickson

author

2007-03-19 15:58 UTC #4 lore raw

Quoted 6 lines · Trond Myklebust

Quoted 5 lines · Steve Dickson
Quoted 4 lines · Neil Brown
Quoted 1 line · On Friday March 16, [email protected] wrote:
Any status or hope with these patches??
I have no problem with the nfs-utils patch though obviously I won't commit it until Trond indicates that he will accept the fs/nfs patch.

Quoted 8 lines

Quoted 5 lines
Sounds reasonable...
Trond, any interest in the 4 line patch that would enable turning off readdirplus? The Tru64 folks would definitely appreciate it.. ;-)
Fine by me, but I'm curious as to why you're not doing the same for NFSv4?

Cool... In this particular case, Tru64 does not support v4 so I didn't think it was needed...

steved.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs