mips: PMC MSP71xx core platform

PATCH Marc St-Jean 2 participants 2 messages Mar 19, 2007 – Mar 20, 2007 MIPS

Share & tools

Marc St-Jean

author

2007-03-19 17:59 UTC #0 lore raw

Quoted 8 lines · Atsushi Nemoto

Review
Quoted 2 lines · Marc St-Jean
(quoted diff) +2 -0
+static struct irq_chip msp_cic_irq_controller = {
+     .typename = "MSP_CIC",
The 'typename' is obsolete. Use 'name'. Also, using new flow handler (and GENERIC_HARDIRQS_NO__DO_IRQ in Kconfig) might give you a little bit better performance.

Thanks Atsushi.

By "using new flow handler" do you mean specifying "handle_level_irq", "handle_edge_irq". etc?

Marc

Atsushi Nemoto

2007-03-20 01:06 UTC #1 lore raw

Quoted 2 lines · Marc St-Jean

By "using new flow handler" do you mean specifying "handle_level_irq", "handle_edge_irq". etc?

Yes. Maybe handle_level_irq would be enough. And you can remove .end routine.

---
Atsushi Nemoto