Skip to contentSkip to conversation

coretemp 2/3 Add the coretemp driver

PATCH In review Rudolf Marek 4 participants 5 messages Mar 20, 2007 – Mar 31, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 coretemp 2/3 Add the coretemp driver

Hello Jean,

This is just the fixed version of the driver (the small typo Nicolas pointed out). Please can you test/apply to your stack once we know it is OK and once the 1/3 patch is applied?

Thanks,

This patch adds the support for the digital temperature sensor found in recent Intel Core CPUs.

Signed-off-by Rudolf Marek <r.marek at assembler.cz>

Rudolf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-coretemp-driver.patch
Type: text/x-patch
Size: 12657 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20070320/13d3ad68/attachment.bin

#1 lore raw

PATCH 1/1 coretemp 2/3 Add the coretemp driver

Quoted 6 lines · Rudolf Marek

Hello Jean,

This is just the fixed version of the driver (the small typo Nicolas pointed out). Please can you test/apply to your stack once we know it is OK and once the 1/3 patch is applied?

Quoted 6 lines

Thanks,

This patch adds the support for the digital temperature sensor found in recent Intel Core CPUs.

Signed-off-by Rudolf Marek <r.marek at assembler.cz>

Tested on my Macbook Pro (Core Duo), works fine.

Best regards,

Nicolas

Applied
#2 lore raw

PATCH 1/1 coretemp 2/3 Add the coretemp driver

In reply to Rudolf Marek
Quoted 6 lines · Rudolf Marek

Hello Jean,

This is just the fixed version of the driver (the small typo Nicolas pointed out). Please can you test/apply to your stack once we know it is OK and once the 1/3 patch is applied?

Quoted 6 lines

Thanks,

This patch adds the support for the digital temperature sensor found in recent Intel Core CPUs.

Signed-off-by Rudolf Marek <r.marek at assembler.cz>

Applied, thanks.

Signature · 1 line
Jean Delvare
#3 lore raw
In reply to Rudolf Marek

This may be a little late, but how about a module parameter that sets tjmax (and suppresses the warning). This way if the detection logic fails for some reason, the driver can still be used if the user knows what the tjmax for their processor is.

Quoted 19 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Rudolf Marek
Sent: Tuesday, March 20, 2007 4:55 PM
To: LM Sensors
Cc: [email protected]; Alexey Dobriyan; [email protected]; [email protected]
Subject: [lm-sensors] [PATCH] coretemp 2/3 Add the coretemp driver

Hello Jean,

This is just the fixed version of the driver (the small typo Nicolas pointed
out). Please can you test/apply to your stack once we know it is OK and once the
1/3 patch is applied?

Thanks,

Quoted 8 lines

This patch adds the support for the digital temperature sensor found in recent
Intel Core CPUs.

Rudolf

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#4 lore raw
In reply to Rudolf Marek

Hi George,

Quoted 4 lines · George T. Joseph

This may be a little late, but how about a module parameter that sets tjmax (and suppresses the warning). This way if the detection logic fails for some reason, the driver can still be used if the user knows what the tjmax for their processor is.

If this is only an option, I guess it cannot hurt. I have no strong opinion on the feature itself, Rudolf will know better. But at any rate, it's not too late - open source code is _meant_ to be improved over time.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors