Skip to contentSkip to conversation

Fix QUICC Engine SDMA setup errors

PATCH Applied Chuck Meade 2 participants 2 messages Mar 27, 2007 – Mar 29, 2007 PowerPC

lore
Share & tools
lore

Chuck Meade

author
#0 lore raw

PATCH 1/1 Fix QUICC Engine SDMA setup errors

Correct the alignment of the internal buffer used by the QUICC Engine SDMA controller to 4Kbytes. Correct the shift direction in the logic that sets up the SDMR register for the QUICC Engine SDMA controller.

Signed-off-by Chuck Meade <[email protected]>

---
In addition to fixing the bugs, this version of this patch addresses Segher's concerns about fixing the line break placement. It also addresses Leo's concerns about using the more accurate term "QUICC Engine" rather than "MPC83xx" in the subject and header.

 arch/powerpc/sysdev/qe_lib/qe.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/sysdev/qe_lib/qe.c +3 -3
diff -uprN a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
@@ -251,13 +251,13 @@ static int qe_sdma_init(void)
 
 	/* allocate 2 internal temporary buffers (512 bytes size each) for
 	 * the SDMA */
-	sdma_buf_offset = qe_muram_alloc(512 * 2, 64);
+	sdma_buf_offset = qe_muram_alloc(512 * 2, 4096);
 	if (IS_MURAM_ERR(sdma_buf_offset))
 		return -ENOMEM;
 
 	out_be32(&sdma->sdebcr, sdma_buf_offset & QE_SDEBCR_BA_MASK);
-	out_be32(&sdma->sdmr, (QE_SDMR_GLB_1_MSK | (0x1 >>
-					QE_SDMR_CEN_SHIFT)));
+	out_be32(&sdma->sdmr, (QE_SDMR_GLB_1_MSK |
+					(0x1 << QE_SDMR_CEN_SHIFT)));
 
 	return 0;
 }
Applied
#1 lore raw
Quoted 5 lines · Chuck Meade

Correct the alignment of the internal buffer used by the QUICC Engine SDMA controller to 4Kbytes. Correct the shift direction in the logic that sets up the SDMR register for the QUICC Engine SDMA controller.

Signed-off-by Chuck Meade <[email protected]>
Quoted 8 lines

---
In addition to fixing the bugs, this version of this patch addresses Segher's concerns about fixing the line break placement. It also addresses Leo's concerns about using the more accurate term "QUICC Engine" rather than "MPC83xx" in the subject and header.

 arch/powerpc/sysdev/qe_lib/qe.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

applied.

- k