Skip to contentSkip to conversation

Review: do not hold dm_reg_lock spinlock when calling dm_add_fsys_entry()

PATCH Vlad Apostolov 1 participant 1 message Mar 30, 2007

lore
Share & tools
lore
#0 lore raw

dm_reg_lock spinlock has been held when calling dm_add_fsys_entry()

Attached is a fix.

Regards,
Vlad

fs/dmapi/dmapi_register.c +1 -1
Index: linux/fs/dmapi/dmapi_register.c
===================================================================
@@ -252,6 +252,7 @@ dm_add_fsys_entry(
 		fsrp->fr_next = dm_registers;
 		dm_registers = fsrp;
 		dm_fsys_cnt++;
+		mutex_spinunlock(&dm_reg_lock, lc);
 #ifdef CONFIG_PROC_FS
 		{
 		char buf[100];
@@ -262,7 +263,6 @@ dm_add_fsys_entry(
 		entry->owner = THIS_MODULE;
 		}
 #endif
-		mutex_spinunlock(&dm_reg_lock, lc);
 		return(0);
 	}