Skip to contentSkip to conversation

MMU FWK changes break OMAP1 compilation

DISCUSSION Dirk Behme 2 participants 2 messages Apr 1, 2007 – Apr 2, 2007

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

Recent MMU FWK changes [1] and [2] break at least OMAP1 compilation.

Issues:

- omap1_mmu_interrupt() in arch/arm/mach-omap1/mmu.c uses various MMU_xxx macros, but in arch/arm/mach-omap1/mmu.h they are called OMAP_MMU_xxx.

- omap1_mmu_interrupt() uses MK32 macro, which is defined in ./plat-omap/dsp/dsp.h, which isn't included.

- omap1_mmu_interrupt() still uses MMUFAULT_MASK, which is removed from arch/arm/plat-omap/dsp/mmu.h by [2]. So [1] introduces MMUFAULT_MASK to mach-omap1/mmu.c while [2] removes it from dsp/mmu.h.

- dsp_mmu_itack() in arch/arm/plat-omap/dsp/mmu.h still uses dsp_fault_adr which is removed in same file by [2].

- Some compiler warnings:

arch/arm/plat-omap/dsp/dsp_mem.c: In function 'dsp_mem_ioctl':
arch/arm/plat-omap/dsp/dsp_mem.c:348: warning: unused variable 'ret' arch/arm/plat-omap/dsp/dsp_mem.c:347: warning: unused variable 'dspadr' arch/arm/plat-omap/dsp/mmu.h:88: warning: 'dspadr' is used uninitialized in this function

Anybody with a fix for these?

Cheers

Dirk

[1] <http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=6b13d95d4979ca9df91420fb5ab18fbfee3f9386>

[2] <http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=68a575f924dbe0326ee1e4178f854cfed7933492>

#1 lore raw

I will take care of this.

From: "ext Dirk Behme" <[email protected]>
Subject: MMU FWK changes break OMAP1 compilation
Date: Sun, 01 Apr 2007 11:31:11 +0200

Quoted 42 lines

Recent MMU FWK changes [1] and [2] break at least OMAP1 compilation.

Issues:

- omap1_mmu_interrupt() in arch/arm/mach-omap1/mmu.c uses various MMU_xxx macros, but in arch/arm/mach-omap1/mmu.h they are called OMAP_MMU_xxx.

- omap1_mmu_interrupt() uses MK32 macro, which is defined in ./plat-omap/dsp/dsp.h, which isn't included.

- omap1_mmu_interrupt() still uses MMUFAULT_MASK, which is removed from arch/arm/plat-omap/dsp/mmu.h by [2]. So [1] introduces MMUFAULT_MASK to mach-omap1/mmu.c while [2] removes it from dsp/mmu.h.

- dsp_mmu_itack() in arch/arm/plat-omap/dsp/mmu.h still uses dsp_fault_adr which is removed in same file by [2].

- Some compiler warnings:

arch/arm/plat-omap/dsp/dsp_mem.c: In function 'dsp_mem_ioctl':
arch/arm/plat-omap/dsp/dsp_mem.c:348: warning: unused variable 'ret'
arch/arm/plat-omap/dsp/dsp_mem.c:347: warning: unused variable 'dspadr'
arch/arm/plat-omap/dsp/mmu.h:88: warning: 'dspadr' is used uninitialized in this function

Anybody with a fix for these?

Cheers

Dirk

[1]
<http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=6b13d95d4979ca9df91420fb5ab18fbfee3f9386>

[2]
<http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=68a575f924dbe0326ee1e4178f854cfed7933492>