Skip to contentSkip to conversation

Latest e1000 7.3.20 driver busted with 2.6.20.4

DISCUSSION Jeff V. Merkey 2 participants 5 messages Apr 4, 2007

lore
Share & tools
lore
#0 lore raw

CC [M] drivers/net/chelsio/mv88x201x.o

 CC [M]  drivers/net/chelsio/my3126.o
 LD [M]  drivers/net/chelsio/cxgb.o
 CC      drivers/net/e1000/e1000_main.o

drivers/net/e1000/e1000_main.c:1185:45: error: macro "INIT_WORK" passed 3 arguments, but takes just 2 ared (first use in this function)
drivers/net/e1000/e1000_main.c:1184: error: (Each undeclared identifier is reported only once drivers/net/e1000/e1000_main.c:1184: error: for each function it appears in.) make[3]: *** [drivers/net/e1000/e1000_main.o] Error 1
make[2]: *** [drivers/net/e1000] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Jeff

#1 lore raw
Quoted 4 lines · Jeff V. Merkey

CC [M] drivers/net/chelsio/mv88x201x.o

  CC [M]  drivers/net/chelsio/my3126.o
  LD [M]  drivers/net/chelsio/cxgb.o
  CC      drivers/net/e1000/e1000_main.o
Quoted 8 lines

drivers/net/e1000/e1000_main.c:1185:45: error: macro "INIT_WORK" passed 3 arguments, but takes just 2 ared (first use in this function)
drivers/net/e1000/e1000_main.c:1184: error: (Each undeclared identifier is reported only once drivers/net/e1000/e1000_main.c:1184: error: for each function it appears in.) make[3]: *** [drivers/net/e1000/e1000_main.o] Error 1
make[2]: *** [drivers/net/e1000] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

this is hardly a thread for lkml as you're posting about out out-of-tree driver.
This issue has also been fixed in 7.4.35 which was released last week on
e1000.sf.net. In the future, please post this stuff to [email protected] where we discuss the out-of-tree driver.

Cheers,

Auke

#2 lore raw
Quoted 16 lines · Auke
Quoted 4 lines · Jeff V. Merkey

CC [M] drivers/net/chelsio/mv88x201x.o

  CC [M]  drivers/net/chelsio/my3126.o
  LD [M]  drivers/net/chelsio/cxgb.o
  CC      drivers/net/e1000/e1000_main.o
Quoted 8 lines

drivers/net/e1000/e1000_main.c:1185:45: error: macro "INIT_WORK" passed 3 arguments, but takes just 2 ared (first use in this function)
drivers/net/e1000/e1000_main.c:1184: error: (Each undeclared identifier is reported only once drivers/net/e1000/e1000_main.c:1184: error: for each function it appears in.) make[3]: *** [drivers/net/e1000/e1000_main.o] Error 1
make[2]: *** [drivers/net/e1000] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Quoted 6 lines

this is hardly a thread for lkml as you're posting about out out-of-tree driver. This issue has also been fixed in 7.4.35 which was released last week on e1000.sf.net. In the future, please post this stuff to [email protected] where we discuss the out-of-tree driver.

Cheers,

Auke

Thanks. I'll download Intel's latest driver and test it. I wasn't discussing the out of tree driver (why do you have a broken Linux out of tree driver, BTW? If its for Linux, shouldn't it be updated here first) but the driver in 2.6.20.4 (which is missing support four additional chipsets).

Jeff

#3 lore raw
Quoted 17 lines · Jeff V. Merkey
Quoted 15 lines · Auke
Quoted 12 lines · Jeff V. Merkey

CC [M] drivers/net/chelsio/mv88x201x.o

  CC [M]  drivers/net/chelsio/my3126.o
  LD [M]  drivers/net/chelsio/cxgb.o
  CC      drivers/net/e1000/e1000_main.o

drivers/net/e1000/e1000_main.c:1185:45: error: macro "INIT_WORK" passed 3 arguments, but takes just 2 ared (first use in this function)
drivers/net/e1000/e1000_main.c:1184: error: (Each undeclared identifier is reported only once drivers/net/e1000/e1000_main.c:1184: error: for each function it appears in.) make[3]: *** [drivers/net/e1000/e1000_main.o] Error 1
make[2]: *** [drivers/net/e1000] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Quoted 7 lines
Quoted 6 lines

this is hardly a thread for lkml as you're posting about out out-of-tree driver. This issue has also been fixed in 7.4.35 which was released last week on e1000.sf.net. In the future, please post this stuff to [email protected] where we discuss the out-of-tree driver.

Cheers,

Auke

Thanks. I'll download Intel's latest driver and test it. I wasn't discussing the out of tree driver (why do you have a broken Linux out of tree driver, BTW? If its for Linux, shouldn't it be updated here first) but the driver in 2.6.20.4 (which is missing support four additional chipsets).

Our hardware release schedule is not aligned with kernel releases, and customers need to have a working (and tested) driver once the hardware is released. We try to get the updates into the kernel as fast as we can, but often meet resistance, as the two parties involved just have different interests.

Are you saying that the in-kernel driver in 2.6.20.4 is broken? That is bizarre, and should never happen. It compiles fine for me here...

Auke

#4 lore raw
Quoted 24 lines · Auke
Quoted 22 lines · Jeff V. Merkey
Quoted 20 lines · Auke
Quoted 4 lines · Jeff V. Merkey

CC [M] drivers/net/chelsio/mv88x201x.o

  CC [M]  drivers/net/chelsio/my3126.o
  LD [M]  drivers/net/chelsio/cxgb.o
  CC      drivers/net/e1000/e1000_main.o
Quoted 8 lines

drivers/net/e1000/e1000_main.c:1185:45: error: macro "INIT_WORK" passed 3 arguments, but takes just 2 ared (first use in this function)
drivers/net/e1000/e1000_main.c:1184: error: (Each undeclared identifier is reported only once drivers/net/e1000/e1000_main.c:1184: error: for each function it appears in.) make[3]: *** [drivers/net/e1000/e1000_main.o] Error 1
make[2]: *** [drivers/net/e1000] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

this is hardly a thread for lkml as you're posting about out out-of-tree driver. This issue has also been fixed in 7.4.35 which was released last week on e1000.sf.net. In the future, please post this stuff to [email protected] where we discuss the out-of-tree driver.

Cheers,

Quoted 10 lines
Quoted 3 lines
Quoted 2 lines

Auke

Thanks. I'll download Intel's latest driver and test it. I wasn't discussing the out of tree driver (why do you have a broken Linux out of tree driver, BTW? If its for Linux, shouldn't it be updated here first) but the driver in 2.6.20.4 (which is missing support four additional chipsets).

Our hardware release schedule is not aligned with kernel releases, and customers need to have a working (and tested) driver once the hardware is released. We try to get the updates into the kernel as fast as we can, but often meet resistance, as the two parties involved just have different interests.

Are you saying that the in-kernel driver in 2.6.20.4 is broken? That is bizarre, and should never happen. It compiles fine for me here...

It's missing support for some of the newer cards. Your sales folks shipped us some newer hardware with the improved e1000, so I will have to adapt the newer drivers to 2.4.20.4. Sounds like you are on top of it and things will sync up eventually. :-)

Jeff