Skip to contentSkip to conversation

utrace: remove exports

PATCH Jim Keniston 1 participant 1 message Apr 19, 2007 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 4 lines · Christoph Hellwig

All the exports in utrace are totally unused, and not really something I'd want modules to use anyway :)

Please leave the exports in place.

Very early in Documentation/utrace.txt, it says:
"The UTRACE is infrastructure code for tracing and controlling user threads. This is the foundation for writing tracing engines, which can be loadable kernel modules."

If we can't use utrace to write ad hoc instrumentation modules (i.e., because utrace_attach(), utrace_detach(), etc. are no longer exported), then utrace's usefulness is greatly reduced.

Jim Keniston
IBM LTC

Quoted 3 lines

...

Quoted 50 lines

Index: linux-2.6/kernel/utrace.c
===================================================================

kernel/utrace.c +1 -10
@@ -490,7 +490,6 @@ restart:
 
 	return engine;
 }
-EXPORT_SYMBOL_GPL(utrace_attach);
 
 /*
  * When an engine is detached, the target thread may still see it and make
@@ -700,8 +699,6 @@ utrace_detach(struct task_struct *target
 
 	return 0;
 }
-EXPORT_SYMBOL_GPL(utrace_detach);
-
 
 /*
  * Called with utrace->lock held.
@@ -900,8 +897,7 @@ restart:			/* See below. */
 
 	return ret;
 }
-EXPORT_SYMBOL_GPL(utrace_set_flags);
-
+
 /*
  * While running an engine callback, no locks are held.
  * If a callback updates its engine's action state, then
@@ -1930,8 +1926,6 @@ utrace_inject_signal(struct task_struct 
 
 	return ret;
 }
-EXPORT_SYMBOL_GPL(utrace_inject_signal);
-
 
 const struct utrace_regset *
 utrace_regset(struct task_struct *target,
@@ -1946,8 +1940,6 @@ utrace_regset(struct task_struct *target
 
 	return &view->regsets[which];
 }
-EXPORT_SYMBOL_GPL(utrace_regset);
-
 
 /*
  * Return the task_struct for the task using ptrace on this one, or NULL.
-