Skip to contentSkip to conversation

LCD driver trims whitespace

parisc-linux Helge Deller 2 participants 6 messages Apr 21, 2007 – Jun 18, 2007 6 messages not in the archive PA-RISC architecture

lore
Share & tools
lore

Helge Deller

author maintainer
#1 lore raw
In reply to a message not in the archive
Quoted 5 lines · Julian Stecklina

I have a HP Visualize workstation with this fancy little LCD at the front controllable via /proc/pdc/lcd. The problem is that the responsible driver trims all trailing whitespace, which is quite annoying if you want to scroll some text. The attached trivial patch (against 2.6.20.1) removes this behaviour.

I'm sure, there was a reason to strip the whitespaces.
But I forgot it by now and it was probably a not very good reason :-)

Nevertheless, the patch looks good.

Kyle, could you add the patch to your git tree ?
-> http://lists.parisc-linux.org/pipermail/parisc-linux/attachments/20070419/d58ce234/no-space-removal.bin

Helge
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

#3 lore raw
In reply to a message not in the archive
Quoted 9 lines · Helge Deller
Quoted 1 line · Julian Stecklina

I have a HP Visualize workstation with this fancy little LCD at the front controllable via /proc/pdc/lcd. The problem is that the responsible driver trims all trailing whitespace, which is quite annoying if you want to scroll some text. The attached trivial patch (against 2.6.20.1) removes this behaviour.

I'm sure, there was a reason to strip the whitespaces. But I forgot it by now and it was probably a not very good reason :-)

Nevertheless, the patch looks good.

Kyle, could you add the patch to your git tree ?
-> http://lists.parisc-linux.org/pipermail/parisc-linux/attachments/20070419/d58ce234/no-space-removal.bin

As I was just browsing the git tree, I did not see the patch. Any reason it was not committed?

Regards,
Julian
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

author maintainer
#5 lore raw
In reply to a message not in the archive
Quoted 11 lines · Julian Stecklina
Quoted 10 lines · Helge Deller
Quoted 5 lines · Julian Stecklina

I have a HP Visualize workstation with this fancy little LCD at the front controllable via /proc/pdc/lcd. The problem is that the responsible driver trims all trailing whitespace, which is quite annoying if you want to scroll some text. The attached trivial patch (against 2.6.20.1) removes this behaviour.

I'm sure, there was a reason to strip the whitespaces.
But I forgot it by now and it was probably a not very good reason :-)

Quoted 7 lines
Quoted 4 lines

Nevertheless, the patch looks good.

Kyle, could you add the patch to your git tree ?
-> http://lists.parisc-linux.org/pipermail/parisc-linux/attachments/20070419/d58ce234/no-space-removal.bin

As I was just browsing the git tree, I did not see the patch. Any reason it was not committed?

It seems it has been forgotten to be merged into Kyle's tree and thus it didn't went upstream.
Please, resend the full patch again to this list, add Kyle McMartin <[email protected]> to CC and (most important) do not forget to add your "signed-off" line.

Thanks,
Helge
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

#7 lore raw

[parisc-linux] LCD driver trims whitespace (again)

In reply to a message not in the archive

Hello,

The attached patch removes the behaviour that writes to /proc/pdc/lcd are whitespace trimmed.

Signed-off-by Helge Deller <[email protected]>

(See thread "LCD driver trims whitespace" for reference.)

Regards,
Julian
--
Julian Stecklina
http://berzerkely.net/

"Dealing with failure is easy: Work hard to improve. Success is also easy to handle: You've solved the wrong problem. Work hard to improve." - Alan Perlis

drivers/parisc/led.c +0 -5
index 98be288..e5d7ed9 100644
@@ -195,12 +195,6 @@ static int led_proc_write(struct file *file, const char *buf,
 
 	cur = lbuf;
 
-	/* skip initial spaces */
-	while (*cur && isspace(*cur))
-	{
-		cur++;
-	}
#9 lore raw

[parisc-linux] LCD driver trims whitespace (again again)

In reply to a message not in the archive

Hello,

Due to my violation of rules, here comes it again...

The attached patch removes the behaviour that writes to /proc/pdc/lcd are whitespace trimmed. This patch applies to Kyle's parisc git tree.

Signed-off-by Julian Stecklina <[email protected]>

(See thread "LCD driver trims whitespace" for reference.)

Regards,
Julian

drivers/parisc/led.c +0 -5
index 98be288..e5d7ed9 100644
@@ -195,12 +195,6 @@ static int led_proc_write(struct file *file, const char *buf,
 
 	cur = lbuf;
 
-	/* skip initial spaces */
-	while (*cur && isspace(*cur))
-	{
-		cur++;
-	}
author maintainer Acked-by
#11 lore raw

Re: [parisc-linux] LCD driver trims whitespace (again again)

In reply to a message not in the archive
Quoted 4 lines · Julian Stecklina

The attached patch removes the behaviour that writes to /proc/pdc/lcd are whitespace trimmed. This patch applies to Kyle's parisc git tree.

Signed-off-by Julian Stecklina <[email protected]>
Acked-by Helge Deller <[email protected]>

_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux