Skip to contentSkip to conversation

Recent ipr breakage (ata_do_eh api change)

DISCUSSION Brian King 2 participants 2 messages May 4, 2007 libata

lore
Share & tools
lore

Brian King

author
#0 lore raw

I just noticed that the following patch (git-libata-all-ipr-fix) is currently in mainline which results in inducing a compiler warning:

http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=120bda35ff8514c937dac6d4e5c7dc6c01c699ac;hp=771b8dad9653d2659e0ffcc237184cb16c317788

This looks like a fix for a compile problem with the libata-all branch. I did some poking around and it looks like the ata_do_eh api change is in Jeff's #all branch, but not in #upstream, so I am assuming the ipr patch mentioned above should be reverted in mainline for now.

Thanks,

Brian

Signature · 3 lines
Brian King
eServer Storage I/O
IBM Linux Technology Center
#1 lore raw
Quoted 5 lines · Brian King

This looks like a fix for a compile problem with the libata-all branch. I did some poking around and it looks like the ata_do_eh api change is in Jeff's #all branch, but not in #upstream, so I am assuming the ipr patch mentioned above should be reverted in mainline for now.

At the moment, there is no #upstream branch. It's all, um, upstream :)

What you see in #ALL is the combination of #reset-seq and #mv-ahci branches.

Jeff