Please revert 464bdd33e9baad9806c7adbd8dfc37081a55f27e
Checkin 464bdd33e9baad9806c7adbd8dfc37081a55f27e "fbdev: ignore VESA modes if framebuffer is disabled" is just plain wrong on any system which has support for extended text modes in its VESA BIOS.
Antonio is incorrectly assuming this branchout is used only to set VESA graphics modes, but it's to set any VESA mode, be it text or graphics.
-pa
Quoted 6 lines · H. Peter Anvin
Checkin
464bdd33e9baad9806c7adbd8dfc37081a55f27e"fbdev: ignore VESA modes if framebuffer is disabled" is just plain wrong on any system which has support for extended text modes in its VESA BIOS.Antonio is incorrectly assuming this branchout is used only to set VESA graphics modes, but it's to set any VESA mode, be it text or graphics.
I wonder if this fbdev update is what causes my X session to die?
I'm using the VESA driver on my ATI R580, and just filed this bug report minutes ago: http://lkml.org/lkml/2007/5/8/667
Jeff
Quoted 5 lines · Jeff Garzik
Quoted 4 lines · H. Peter Anvin
Checkin
464bdd33e9baad9806c7adbd8dfc37081a55f27e"fbdev: ignore VESA modes if framebuffer is disabled" is just plain wrong on any system which has support for extended text modes in its VESA BIOS.
Quoted 8 lines
Quoted 2 lines
Antonio is incorrectly assuming this branchout is used only to set VESA graphics modes, but it's to set any VESA mode, be it text or graphics.
I wonder if this fbdev update is what causes my X session to die?
I'm using the VESA driver on my ATI R580, and just filed this bug report minutes ago: http://lkml.org/lkml/2007/5/8/667
Perhaps, but not due to this partiular patch. :)
-hpa
Quoted 2 lines · Jeff Garzik
I wonder if this fbdev update is what causes my X session to die?
Not that particular patch, but yeah, it could certainly be the fbdev update.
Can you try bisecting it?
Linus
Quoted 7 lines · Linus Torvalds
Quoted 1 line · Jeff Garzik
I wonder if this fbdev update is what causes my X session to die?
Not that particular patch, but yeah, it could certainly be the fbdev update.
Can you try bisecting it?
Planning to, but not tonight.
Jeff
Quoted 7 lines · H. Peter Anvin
Checkin
464bdd33e9baad9806c7adbd8dfc37081a55f27e"fbdev: ignore VESA modes if framebuffer is disabled" is just plain wrong on any system which has support for extended text modes in its VESA BIOS.Antonio is incorrectly assuming this branchout is used only to set VESA graphics modes, but it's to set any VESA mode, be it text or graphics.
Okay.
Tony
Quoted 11 lines · Antonino A. Daplas
Quoted 7 lines · H. Peter Anvin
Checkin
464bdd33e9baad9806c7adbd8dfc37081a55f27e"fbdev: ignore VESA modes if framebuffer is disabled" is just plain wrong on any system which has support for extended text modes in its VESA BIOS.Antonio is incorrectly assuming this branchout is used only to set VESA graphics modes, but it's to set any VESA mode, be it text or graphics.
Okay.
I did, however, take a cue from this and the setup rewrite now makes the VESA graphics mode unselectable if CONFIG_FB is off.
See:
http://git.kernel.org/?p=linux/kernel/git/hpa/linux-2.6-newsetup.git;a=shortlog
-hpa
Quoted 9 lines · Jeff Garzik
Quoted 6 lines · H. Peter Anvin
Checkin
464bdd33e9baad9806c7adbd8dfc37081a55f27e"fbdev: ignore VESA modes if framebuffer is disabled" is just plain wrong on any system which has support for extended text modes in its VESA BIOS.Antonio is incorrectly assuming this branchout is used only to set VESA graphics modes, but it's to set any VESA mode, be it text or graphics.
I wonder if this fbdev update is what causes my X session to die?
That's doubtful though, CONFIG_FB=n. For a start, you can try reverting changes in drivers/char/vt.c and drivers/video/console/vgacon.c
Tony
Quoted 10 lines · H. Peter Anvin
Quoted 9 lines · Antonino A. Daplas
Quoted 7 lines · H. Peter Anvin
Checkin
464bdd33e9baad9806c7adbd8dfc37081a55f27e"fbdev: ignore VESA modes if framebuffer is disabled" is just plain wrong on any system which has support for extended text modes in its VESA BIOS.Antonio is incorrectly assuming this branchout is used only to set VESA graphics modes, but it's to set any VESA mode, be it text or graphics.
Quoted 6 lines
Quoted 2 lines
Okay.
I did, however, take a cue from this and the setup rewrite now makes the VESA graphics mode unselectable if
CONFIG_FBis off.
Ah, okay, thanks.
Tony