libata: give devices one last chance even if recovery failed with -EINVAL

PATCH Applied Tejun Heo 2 participants 2 messages May 11, 2007 libata

Share & tools

Tejun Heo

author

2007-05-11 12:47 UTC #0 lore raw

PATCH 1/1 libata: give devices one last chance even if recovery failed with -EINVAL

After certain errors, some devices report complete garbage on IDENTIFY. This can cause ata_dev_read_id() to fail with -EINVAL resulting in immediate disabling of the device. Give the device one last chance after -EINVAL to allow recovery from such situations. As -EINVAL is triggered very rarely, this shouldn't cause any noticeable affect on more common error paths.

Signed-off-by Tejun Heo <[email protected]>

Cc Harald Dunkel <[email protected]>

drivers/ata/libata-eh.c +1 -5

index 8256655..d7f62c7 100644
@@ -2201,14 +2201,10 @@ static int ata_eh_recover(struct ata_por
 	ehc->tries[dev->devno]--;
 
 	switch (rc) {
-	case -EINVAL:
-		/* eeek, something went very wrong, give up */
-		ehc->tries[dev->devno] = 0;
-		break;
-
 	case -ENODEV:
 		/* device missing or wrong IDENTIFY data, schedule probing */
 		ehc->i.probe_mask |= (1 << dev->devno);
+	case -EINVAL:
 		/* give it just one more chance */
 		ehc->tries[dev->devno] = min(ehc->tries[dev->devno], 1);
 	case -EIO:

Jeff Garzik

Applied

2007-05-11 22:11 UTC #1 lore raw

Quoted 9 lines · Tejun Heo

After certain errors, some devices report complete garbage on IDENTIFY. This can cause ata_dev_read_id() to fail with -EINVAL resulting in immediate disabling of the device. Give the device one last chance after -EINVAL to allow recovery from such situations. As -EINVAL is triggered very rarely, this shouldn't cause any noticeable affect on more common error paths.
Signed-off-by Tejun Heo <[email protected]>
Cc Harald Dunkel <[email protected]>

applied