Skip to contentSkip to conversation

spi: potential memleak in spidev_ioctl

PATCH New Florin Malita 1 participant 1 message May 16, 2007 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: potential memleak in spidev_ioctl

'ioc' should be deallocated if __copy_from_user fails (found by Coverity - CID 1644).

---

spidev.c | 1 +

1 file changed, 1 insertion(+)
drivers/spi/spidev.c +0 -0
index c0a6dce..2464f34 100644
@@ -364,6 +364,7 @@ spidev_ioctl(struct inode *inode, struct file *filp,
			break;
		}
		if (__copy_from_user(ioc, (void __user *)arg, tmp)) {
+			kfree(ioc);
			retval = -EFAULT;
			break;
		}