SM56 Modem in Asus A8J Notebook Series
PATCH 1/1 SM56 Modem in Asus A8J Notebook Series
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi there
after I submitted the solution 5 month ago in the Bug system, I am trying it now directly. Attached to this posting is the necessary patch to get this modem working with slmodemd.
The Patch is against alsa-driver-1.0.14rc4/alsa-kernel/pci/hda/patch_si3054.c
if included it's Bug #0002732, assigned to tiwai.
Greetings Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGTadQYMBp7Qf+VpkRAp8MAJ9lii0FA/lBZPRabFxWIiVVJnAh7wCdGEkk fH0mFw4iOP3S9BHcTor3qVo=
=suhj
-----END PGP SIGNATURE-----
patch_si3054.c +1 -0
@@ -305,6 +305,7 @@ { .id = 0x10573055, .name = "Si3054", .patch = patch_si3054 }, { .id = 0x10573057, .name = "Si3054", .patch = patch_si3054 }, { .id = 0x10573155, .name = "Si3054", .patch = patch_si3054 }, + { .id = 0x15433155, .name = "Si3054", .patch = patch_si3054 }, /*Asus A8J Modem (SM56)*/ {} };
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Fri, 18 May 2007 15:17:05 +0200,
Quoted 11 lines · Christian Rothländer
Hi there
after I submitted the solution 5 month ago in the Bug system, I am trying it now directly. Attached to this posting is the necessary patch to get this modem working with slmodemd.
The Patch is against
alsa-driver-1.0.14rc4/alsa-kernel/pci/hda/patch_si3054.cif included it's Bug #0002732, assigned to tiwai.
Greetings Christian
Thanks, the patch looks good to me.
Could you give a brief description of the patch and your sign-off to merge to the upstream?
thanks,
Takashi
Quoted 26 lines
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.orgiD8DBQFGTadQYMBp7Qf+VpkRAp8MAJ9lii0FA/lBZPRabFxWIiVVJnAh7wCdGEkk fH0mFw4iOP3S9BHcTor3qVo=
=suhj
-----END PGP SIGNATURE-----
[1.1.2 SM56.patch <text/plain (7bit)>]patch_si3054.c +1
-0@@ -305,6 +305,7 @@ { .id = 0x10573055, .name = "Si3054", .patch = patch_si3054 }, { .id = 0x10573057, .name = "Si3054", .patch = patch_si3054 }, { .id = 0x10573155, .name = "Si3054", .patch = patch_si3054 }, + { .id = 0x15433155, .name = "Si3054", .patch = patch_si3054 }, /*Asus A8J Modem (SM56)*/ {} };[1.2 S/MIME Cryptographic Signature <application/x-pkcs7-signature (base64)>]
[2 <text/plain; us-ascii (7bit)>]
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 3 lines
Quoted 3 lines
It's a process to merge to the upstream kernel. We need to give a kind of approval from the patch authors and contributors. It consists of a line
ok .. something new for me :-)
Here it goes:
================================================================
hda-codec - patch_si3045.c
This patch adds support for the ASUS A8J Series 56k Modem (Motorola SM56)
THE PATCH STARTS BELOW
================================================================
Quoted 12 lines
Just a small issue is left. With the alsa driver buildin into 2.6.19 slmodem is working, with any newer one (either
standalone or buildin driver) we have a "hda-intel: invalidformat_val, rate=9600, ch=1, format=2" error in dmesg. Seems something has been broken on that step (probably 1.0.13 to 1.0.14?). Sadly I'm not able to tell right now which alsa was included into 2.6.19. I'm trying to compare the files to get an idea what's wrong (#2799 and #2820 are reporting similar problems).Quoted 3 lines
This should have been fixed in the recent version. The driver dropped the support of 9600HZ accidentally.
That's really good to hear. Can you close the Bug entry #2732 then? (#2799 and #2820 can be closed too, if the 9600 Hz problem is solved)
So thanks a lot ...
Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGTbwUYMBp7Qf+VpkRApyKAJ4xfBkrLiG1D7whZIV1CteUTRhFagCfd/LU 2jeMsy1MQ/WxX5A7P/iThjM=
=A9s6
-----END PGP SIGNATURE-----
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Fri, 18 May 2007 16:45:40 +0200,
Quoted 13 lines · Christian Rothländer
Quoted 4 lines
Quoted 4 lines
It's a process to merge to the upstream kernel. We need to give a kind of approval from the patch authors and contributors. It consists of a line
ok .. something new for me :-)
Here it goes:Signed-off-by Christian Rothlaender <[email protected]>================================================================
hda-codec -patch_si3045.c
Quoted 6 lines
This patch adds support for the ASUS A8J Series 56k Modem (Motorola SM56)
Signed-off-by Christian Rothlaender <[email protected]>THE PATCH STARTS BELOW
================================================================
Thanks. I meant 'THE PATCH STARTS BELOW' as to paste the actual patch content there :) Also, the first line is the patch summary, which explains the patch briefly.
Anyway, I applied your patch to ALSA HG tree now.
It should be included in the next 1.0.14 (hopefully final) release.
Quoted 11 lines
Quoted 11 lines
Just a small issue is left. With the alsa driver buildin into 2.6.19 slmodem is working, with any newer one (either
standalone or buildin driver) we have a "hda-intel: invalidformat_val, rate=9600, ch=1, format=2" error in dmesg. Seems something has been broken on that step (probably 1.0.13 to 1.0.14?). Sadly I'm not able to tell right now which alsa was included into 2.6.19. I'm trying to compare the files to get an idea what's wrong (#2799 and #2820 are reporting similar problems).Quoted 1 line
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
This should have been fixed in the recent version. The driver dropped the support of 9600HZ accidentally.
That's really good to hear. Can you close the Bug entry #2732 then? (#2799 and #2820 can be closed too, if the 9600 Hz problem is solved)
OK, will do.
Thanks!
Takashi