Skip to contentSkip to conversation

building i386 requires s390: "driver/crypto/Kconfig" sourcing s390 arch

DISCUSSION Linda Walsh 5 participants 9 messages May 18, 2007 – May 20, 2007

lore
Share & tools
lore
#0 lore raw

Seems there is an include of s390 based config in file drivers/crypto/Kconfig: source "arch/s390/crypto/Kconfig"

The line doesn't seem to be need for an i386 build (haven't tried x86_64 though).

I take it that this was a braino?

#1 lore raw
Quoted 7 lines · On Fri, 18 May 2007 12:32:47 -0700 Linda Walsh wrote:

Seems there is an include of s390 based config in file drivers/crypto/Kconfig: source "arch/s390/crypto/Kconfig"

The line doesn't seem to be need for an i386 build (haven't tried x86_64 though).

I take it that this was a braino?

Does it cause a problem? If yes, what problem?

It looks like someone thought that all Hardware crypto devices should be listed under the same menu heading. Makes some sense.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#2 lore raw
Quoted 6 lines · Randy Dunlap
Quoted 3 lines · On Fri, 18 May 2007 12:32:47 -0700 Linda Walsh wrote:

Seems there is an include of s390 based config in file drivers/crypto/Kconfig: source "arch/s390/crypto/Kconfig"

Quoted 8 lines
Quoted 5 lines

The line doesn't seem to be need for an i386 build (haven't tried x86_64 though).

I take it that this was a braino?

Does it cause a problem? If yes, what problem?

----
Yes. My source tree has unrelated architectures removed,
as a result when building i386 or x86_64, the config tools try to
include files from the s390 architecture. It isn't there. I'm building x86, why should I be including files from other architectures. It is hierarchically unclean.

Perhaps the s390 device needs to be moved under the crypto with
the other crypto devices? If the standard that other architectures are
using is to put their devices in the crypto directory, then one might expect all crypto devices to be there. Why should s390 stick out and put its crypto device someplace under the s390 tree, forcing parts of the s390 tree to be included when building other architectures?

Quoted 3 lines

It looks like someone thought that all Hardware crypto devices should be listed under the same menu heading. Makes some sense.

I thought the idea was the menu reflected the options available in the specific parts/branches -- i.e. if you have the menu option in the crypto tree, then the source code should be there as well.

I'm not sure how flexible the include system is, but can't it be "not included" unless compiling for ARCH_s390?

#3 lore raw
Quoted 13 lines · On Fri, 18 May 2007 14:46:02 -0700 Linda Walsh wrote:
Quoted 12 lines · Randy Dunlap
Quoted 8 lines · On Fri, 18 May 2007 12:32:47 -0700 Linda Walsh wrote:

Seems there is an include of s390 based config in file drivers/crypto/Kconfig: source "arch/s390/crypto/Kconfig"

The line doesn't seem to be need for an i386 build (haven't tried x86_64 though).

I take it that this was a braino?

Quoted 8 lines
Quoted 2 lines

Does it cause a problem? If yes, what problem?

----
Yes. My source tree has unrelated architectures removed,
as a result when building i386 or x86_64, the config tools try to include files from the s390 architecture. It isn't there. I'm building x86, why should I be including files from other architectures. It is hierarchically unclean.

Yes, it is. What removes all arch-except-i386-and-x86_64 from your kernel tree? Can't it also do

$ sed @source "arch/s390/crypto/Kconfig"@#source "arch/s390/crypto/Kconfig"@
at the same time?

Who supports a pared-down kernel tree like this?

Quoted 2 lines

Perhaps the s390 device needs to be moved under the crypto with
the other crypto devices?

Sorry, I didn't quite understand that part.

Quoted 5 lines

If the standard that other architectures are
using is to put their devices in the crypto directory, then one might expect all crypto devices to be there. Why should s390 stick out and put its crypto device someplace under the s390 tree, forcing parts of the s390 tree to be included when building other architectures?

drivers/crypto/ currently contains drivers for x86_32 and s390 (the latter by indirection, which is what is causing you this grief/problem/whatever), but it certainly looks like it could be a home for crypto drivers on any arch.

Quoted 6 lines
Quoted 3 lines

It looks like someone thought that all Hardware crypto devices should be listed under the same menu heading. Makes some sense.

I thought the idea was the menu reflected the options available in the specific parts/branches -- i.e. if you have the menu option in the crypto tree, then the source code should be there as well.

I'm not aware of that. E.g., i386 and x86_64 share a lot of code via "#include ../foo/bar" (and it's bad/ugly).

Quoted 2 lines

I'm not sure how flexible the include system is, but can't it be "not included" unless compiling for ARCH_s390?

That would be the best solution IMO, if it only worked. :(

E.g.:

if S390
source "arch/s390/crypto/Kconfig"
endif

in drivers/crypto/Kconfig. Alas, it doesn't work.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#4 lore raw
Quoted 8 lines · Randy Dunlap
Quoted 5 lines · On Fri, 18 May 2007 14:46:02 -0700 Linda Walsh wrote:

If the standard that other architectures are using is to put their devices in the crypto directory, then one might expect all crypto devices to be there. Why should s390 stick out and put its crypto device someplace under the s390 tree, forcing parts of the s390 tree to be included when building other architectures?

Quoted 4 lines

drivers/crypto/ currently contains drivers for x86_32 and s390 (the latter by indirection, which is what is causing you this grief/problem/whatever), but it certainly looks like it could be a home for crypto drivers on any arch.

this all sounds vaguely familiar. oh, wait ...

http://lkml.org/lkml/2007/3/28/212

rday

Signature · 7 lines
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
#5 lore raw
Quoted 9 lines · Robert P. J. Day
Quoted 7 lines · Randy Dunlap
Quoted 5 lines · On Fri, 18 May 2007 14:46:02 -0700 Linda Walsh wrote:

If the standard that other architectures are using is to put their devices in the crypto directory, then one might expect all crypto devices to be there. Why should s390 stick out and put its crypto device someplace under the s390 tree, forcing parts of the s390 tree to be included when building other architectures?

Quoted 8 lines
Quoted 4 lines

drivers/crypto/ currently contains drivers for x86_32 and s390 (the latter by indirection, which is what is causing you this grief/problem/whatever), but it certainly looks like it could be a home for crypto drivers on any arch.

this all sounds vaguely familiar. oh, wait ...

http://lkml.org/lkml/2007/3/28/212

I just tried several things to "fix" it, but none of them worked.

I wouldn't mind making missing files in *config be non-fatal, i.e., just print a warning message, but I doubt that the maintainer(s) would accept that.

Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
#6 lore raw
In reply to Randy Dunlap
Quoted 24 lines · Randy Dunlap
Quoted 13 lines · On Fri, 18 May 2007 14:46:02 -0700 Linda Walsh wrote:
Quoted 12 lines · Randy Dunlap
Quoted 8 lines · On Fri, 18 May 2007 12:32:47 -0700 Linda Walsh wrote:

Seems there is an include of s390 based config in file drivers/crypto/Kconfig: source "arch/s390/crypto/Kconfig"

The line doesn't seem to be need for an i386 build (haven't tried x86_64 though).

I take it that this was a braino?

Quoted 8 lines
Quoted 2 lines

Does it cause a problem? If yes, what problem?

----
Yes. My source tree has unrelated architectures removed,
as a result when building i386 or x86_64, the config tools try to include files from the s390 architecture. It isn't there. I'm building x86, why should I be including files from other architectures. It is hierarchically unclean.

Quoted 6 lines

Yes, it is. What removes all arch-except-i386-and-x86_64 from your kernel tree? Can't it also do

$ sed @source "arch/s390/crypto/Kconfig"@#source "arch/s390/crypto/Kconfig"@
at the same time?

Who supports a pared-down kernel tree like this?

On op of this I have previously discussed with Roman Zippel the possibility to have _one_ include hirachy for Kconfig files. So that kconfig would fetch all Kconfig files for all archs.

Sam

#7 lore raw
In reply to Randy Dunlap
Quoted 4 lines · Randy Dunlap

if S390
source "arch/s390/crypto/Kconfig"
endif

Why bother? Why not just move the contents of s390's crypto "Kconfig" in place of the "source" statement. All the options in s390's Kconfig are already conditional depending on S390.

The contents simply need to be [moved] in[to] the the main crypto config file (./drivers/crypto/Kconfig).

It "works" fine on i386, don't see why it wouldn't build on any other arch.

#8 lore raw
Quoted 9 lines · Linda Walsh
Quoted 4 lines · Randy Dunlap

if S390
source "arch/s390/crypto/Kconfig"
endif

Why bother? Why not just move the contents of s390's crypto "Kconfig" in place of the "source" statement. All the options in s390's Kconfig are already conditional depending on S390.

Quoted 5 lines

The contents simply need to be [moved] in[to] the the main crypto config file (./drivers/crypto/Kconfig).

It "works" fine on i386, don't see why it wouldn't build on any other arch.

Send a patch.