Skip to contentSkip to conversation

ACPI: bay: send envp with uevent - fix

PATCH Stephan Berberig 1 participant 2 messages Jun 9, 2007 – Jun 22, 2007 ACPI

lore
Share & tools
lore
#0 lore raw

Hi,
attached a patch to fix the bay uevent so that udev doesn't get confused.

Kristen, could I get your Acked-by?

Best regards,
Stephan

There must not be a new-line character in the uevent. Otherwise, udev gets confused. Thanks to Kay Sievers for pointing it out.

CC Kristen Carlson Accardi <[email protected]>
drivers/acpi/bay.c +1 -1
@@ -337,7 +337,7 @@
 	char *envp[] = { event_string, NULL };
 
 	bay_dprintk(handle, "Bay event");
-	sprintf(event_string, "BAY_EVENT=%d\n", event);
+	sprintf(event_string, "BAY_EVENT=%d", event);
 	kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, envp);
 }
 
#1 lore raw

Hi Len,

any news about applying this patch to acpi-test?

I got Kristen's Acked-by by private email.

Best regards,
Stephan

Quoted 28 lines · Stephan Berberig

Hi,
attached a patch to fix the bay uevent so that udev doesn't get confused.

Kristen, could I get your Acked-by?

Best regards,
Stephan

------------------------------------------------------------------------

There must not be a new-line character in the uevent. Otherwise, udev gets confused. Thanks to Kay Sievers for pointing it out.

CC Kristen Carlson Accardi <[email protected]>
drivers/acpi/bay.c +1 -1
@@ -337,7 +337,7 @@
 	char *envp[] = { event_string, NULL };
 
 	bay_dprintk(handle, "Bay event");
-	sprintf(event_string, "BAY_EVENT=%d\n", event);
+	sprintf(event_string, "BAY_EVENT=%d", event);
 	kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, envp);
 }