Skip to contentSkip to conversation

mips: PMC MSP71xx core platform

PATCH Marc St-Jean 1 participant 1 message Jun 20, 2007 MIPS

lore
Share & tools
lore
#0 lore raw
Quoted 9 lines · Ralf Baechle
Quoted 2 lines · Marc St-Jean

Re-posting patch as requested by Ralf. Changes since last post:
-Minor cleanups as recommended by checkpatch.pl.

Be careful with that script. Some of it's recommendations are harmful, for example when it sees an inclusion of <asm/time.h> it will suggest to use <linux/time.h>. That's all fine because generally the file under linux/ will include the asm/ version but there are exception.

I discovered that on some patches, a few had to be reverted but no problem.

Quoted 23 lines

But it's great that you discovered it already, it saves me the for both sides annoying part of dealing out tons of trivialities, first such as formatting trivialities. One thing checkpatch.pl doesn't yet complain about is trailing whitespace such as in the first of the patches you sent:

Warning: trailing whitespace in line 106 of arch/mips/pmc-sierra/msp71xx/msp_usb.c
Warning: trailing whitespace in line 12 of arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c
Warning: trailing whitespace in lines 43,53,63,79 of arch/mips/pmc-sierra/msp71xx/msp_time.c
Warning: trailing whitespace in lines 49,59,62,68,78,84 of arch/mips/pmc-sierra/msp71xx/msp_irq.c
Warning: trailing whitespace in line 84 of arch/mips/pmc-sierra/msp71xx/msp_irq_cic.c
Warning: trailing whitespace in line 157 of arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
Warning: trailing whitespace in lines 154,307,537,548,558 of arch/mips/pmc-sierra/msp71xx/msp_prom.c
Warning: trailing whitespace in lines 66,229,238,252 of arch/mips/pmc-sierra/msp71xx/msp_setup.c

Quoted 1 line

No need to resend the patch, I can strip that of trivially

Hmmm, I see. That's odd since it catches most trailing whitespace. I'll email the maintainer if you haven't already. I've reported two other issues to him before and he fixed the script in a day!

Marc