libata: fix ata_dev_disable()
PATCH 1/1 libata: fix ata_dev_disable()
Fix silly condition check bug in ata_dev_disable().
Signed-off-by Tejun Heo <[email protected]>
--- drivers/ata/libata-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/ata/libata-core.c +3 -2
@@ -600,8 +600,9 @@ static const char *sata_spd_string(unsigned int spd)void ata_dev_disable (struct ata_device *dev) { -if (ata_dev_enabled (dev) &&ata_msg_drv (dev->ap)) { -ata_dev_printk (dev,KERN_WARNING ,"disabled\n" ); +if (ata_dev_enabled (dev)) { +if (ata_msg_drv (dev->ap)) +ata_dev_printk (dev,KERN_WARNING ,"disabled\n" );ata_down_xfermask_limit (dev,ATA_DNXFER_FORCE_PIO0 |ATA_DNXFER_QUIET ); dev->class++;
Jeff Garzik
AppliedQuoted 12 lines · Tejun Heo
Fix silly condition check bug in
ata_dev_disable().Signed-off-by Tejun Heo <[email protected]>--- drivers/ata/libata-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/ata/libata-core.c +0
-0
drivers/ata/libata-core.c static const char *sata_spd_string(unsigned int spd) · line 607
Quoted 10 lines
drivers/ata/libata-core.c +3
-2@@ -600,8 +600,9 @@ static const char *sata_spd_string(unsigned int spd)void ata_dev_disable (struct ata_device *dev) { -if (ata_dev_enabled (dev) &&ata_msg_drv (dev->ap)) { -ata_dev_printk (dev,KERN_WARNING ,"disabled\n" ); +if (ata_dev_enabled (dev)) { +if (ata_msg_drv (dev->ap)) +ata_dev_printk (dev,KERN_WARNING ,"disabled\n" );ata_down_xfermask_limit (dev,ATA_DNXFER_FORCE_PIO0 |ATA_DNXFER_QUIET );
applied