Another Maxtor drive with broken NCQ
From:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246352
Looks like this entry is needed in the NCQ blacklist:
{"Maxtor 6B200M0", "BANC1BM0", ATA_HORKAGE_NONCQ }
Or should *all* Maxtor 6B200M0 be blacklisted, since there's already one of them in the list?
Quoted 9 lines · Chuck Ebbert
From:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246352Looks like this entry is needed in the NCQ blacklist:
{"Maxtor 6B200M0", "BANC1BM0",
ATA_HORKAGE_NONCQ}Or should *all* Maxtor 6B200M0 be blacklisted, since there's already one of them in the list?
Wanna send that as a patch, with attribution and sign-offs? :)
Jeff
Quoted 8 lines · Jeff Garzik
Quoted 5 lines
{"Maxtor 6B200M0", "BANC1BM0",
ATA_HORKAGE_NONCQ}Or should *all* Maxtor 6B200M0 be blacklisted, since there's already one of them in the list?
Wanna send that as a patch, with attribution and sign-offs? :)
For all revisions, or just that one new one?
Quoted 9 lines · Chuck Ebbert
Quoted 6 lines · Jeff Garzik
Quoted 4 lines
{"Maxtor 6B200M0", "BANC1BM0",
ATA_HORKAGE_NONCQ}Or should *all* Maxtor 6B200M0 be blacklisted, since there's already one of them in the list?
Wanna send that as a patch, with attribution and sign-offs? :)
For all revisions, or just that one new one?
I don't think all 6B200M0 should be blacklisted, but BANC* is probably bad. I don't think the code can do wildcard matching, so just the one revision is probably the best we can do at the moment.
Jeff
Quoted 6 lines · On Sat, 07 Jul 2007 10:51:14 -0400 Jeff Garzik <[email protected]> wrote:
Quoted 5 lines · Chuck Ebbert
Quoted 4 lines · Jeff Garzik
Quoted 4 lines
{"Maxtor 6B200M0", "BANC1BM0",
ATA_HORKAGE_NONCQ}Or should *all* Maxtor 6B200M0 be blacklisted, since there's already one of them in the list?
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Wanna send that as a patch, with attribution and sign-offs? :)
For all revisions, or just that one new one?
I don't think all 6B200M0 should be blacklisted, but BANC* is probably bad. I don't think the code can do wildcard matching, so just the one revision is probably the best we can do at the moment.
Regexp is a bit extreme but a simple "anything starting.." (untested) would be ok
ata/libata-core.c renamed from ata/libata-core.c~ +10 -2
@@ -3869,10 +3869,18 @@while (ad->model_num) {if (!strcmp (ad->model_num, model_num)) { +unsigned char *tp;if (ad->model_rev ==NULL )return ad->horkage; -if (!strcmp (ad->model_rev, model_rev)) -return ad->horkage; + t =strchr (ad->model_rev,'*' ); +if (t ==NULL ) { +if (!strcmp (ad->model_rev, model_rev)) +return ad->horkage; + }else { +if (!strncmp (ad->model_rev, model_rev, + t-model_rev)) +return ad->horkage; + } } ad++; }