Skip to contentSkip to conversation

: Fix meta ematch usage of 0 values

IPROUTE Patrick McHardy 1 participant 1 message Jul 11, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

[IPROUTE]: Fix meta ematch usage of 0 values

em_meta doesn't send 0 values to the kernel. breaking matching on them and resulting in "Missing value TLV" messages on dump.

tc/em_meta.c +2 -5
index 5fc0c59..b727422 100644
@@ -406,11 +406,8 @@ static int meta_parse_eopt(struct nlmsghdr *n, struct tcf_ematch_hdr *hdr,
 
 	addattr_l(n, MAX_MSG, TCA_EM_META_HDR, &meta_hdr, sizeof(meta_hdr));
 
-	if (lvalue)
-		dump_value(n, TCA_EM_META_LVALUE, lvalue, &meta_hdr.left);
-
-	if (rvalue)
-		dump_value(n, TCA_EM_META_RVALUE, rvalue, &meta_hdr.right);
+	dump_value(n, TCA_EM_META_LVALUE, lvalue, &meta_hdr.left);
+	dump_value(n, TCA_EM_META_RVALUE, rvalue, &meta_hdr.right);
 
 	return 0;
 }