Skip to contentSkip to conversation

Please revert 904f7a3f042b5c6aa9e53ce83f2c9de5e33170ff

DISCUSSION H. Peter Anvin 3 participants 5 messages Jul 13, 2007

lore
Share & tools
lore
#0 lore raw

It causes build failures on i386.

Yet another case of unnecessary divergence between i386 and x86-64 I'm afraid...

-hpa

#1 lore raw
Quoted 4 lines · H. Peter Anvin

It causes build failures on i386.

Yet another case of unnecessary divergence between i386 and x86-64 I'm afraid...

Already fixed in cpufreq.git, pull request about to linus.

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#2 lore raw
Quoted 7 lines · Dave Jones
Quoted 4 lines · H. Peter Anvin

It causes build failures on i386.

Yet another case of unnecessary divergence between i386 and x86-64 I'm afraid...

Already fixed in cpufreq.git, pull request about to linus.

Sigh. And now its reverted.

Can we be a bit less trigger happy about reverting stuff ? Linus, how do you want to proceed, cpufreq.git has that fixed, but will you now have to revert the revert, or will I have to do something?

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#3 lore raw
Quoted 4 lines · Dave Jones

Can we be a bit less trigger happy about reverting stuff ? Linus, how do you want to proceed, cpufreq.git has that fixed, but will you now have to revert the revert, or will I have to do something?

Point mw to your fixed repo, I'll fix it up,

Linus

Acked-by Mark Langsdorf Acked-by Venkatesh Pallipadi
#4 lore raw
Quoted 9 lines · Linus Torvalds
Quoted 4 lines · Dave Jones

Can we be a bit less trigger happy about reverting stuff ? Linus, how do you want to proceed, cpufreq.git has that fixed, but will you now have to revert the revert, or will I have to do something?

Point mw to your fixed repo, I'll fix it up,

Pull req was sent an hour or so ago, here it is again.

Thanks,

Dave

Please pull from .. master.kernel.org:/pub/scm/linux/kernel/git/davej/cpufreq.git/

 Documentation/feature-removal-schedule.txt        |   22 --
 arch/i386/kernel/cpu/cpufreq/Kconfig              |   18 +--
 arch/i386/kernel/cpu/cpufreq/longhaul.c           |    7 +
 arch/i386/kernel/cpu/cpufreq/powernow-k8.c        |   26 ++-
 arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c |  276 ++-------------------
 arch/x86_64/kernel/cpufreq/Kconfig                |    6 +-
 drivers/cpufreq/cpufreq.c                         |   29 ++-
 7 files changed, 65 insertions(+), 319 deletions(-)

commit 9a60ddbcb710ff78cd8c772681723a04e3f5aba3

Author: Dave Jones <[email protected]>
Date:   Fri Jul 13 01:34:10 2007 -0400

[CPUFREQ] Fix typos in powernow-k8 printk's.

Based on a patch from Joachim which didn't apply, so I fixed it up by hand, and also corrected the surrounding indentation a little.

commit 084f34939424161669467c19280dbcf637730314

Author: Thomas Renninger <[email protected]>
Date:   Mon Jul 9 11:35:28 2007 -0700

[CPUFREQ] Restore previously used governor on a hot-replugged CPU

Negative side effect: needs NR_CPUs pointer array of memory in CONFIG_HOTPLUG_CPU case.

Still needs userspace track keeping and rewriting of governors if governors change while a CPU is not active (always the governor at CPU remove time is restored).

Move of policy->user_policy.governor assignment is just a minor cleanup.
http://bugzilla.kernel.org/show_bug.cgi?id=8671

commit 91973de736bc97dc04156242c5a4b00993b6c902

Author: Peter Oruba <[email protected]>
Date:   Mon Jul 9 11:35:27 2007 -0700

[CPUFREQ] bugfix cpufreq in combination with performance governor

There is a frequency scaling issue that I encountered with the performance governor in combination with CPU hotplug.

In cpufreq.c CPU frequency is reduced to its minimum before the CPU gets unregistered and set offline. Does that have a particular reason?

Since the (k8-)governor does not monitor CPU frequency that setting also applies then to the remaining CPU as well and lets the system run on the lowest frequency although performance is chose as the policy.

commit aac22d0a79f51d7bd93145be36322baaa4b423f8

Author: Andrew Morton <[email protected]>
Date:   Mon Jul 9 11:35:27 2007 -0700

[CPUFREQ] powernow-k8 compile fix.

Make it compile on UP.

commit 68485695e5a84399da7b48b208ac42623fe22963

Author: Adrian Bunk <[email protected]>
Date:   Sun Jul 8 23:39:14 2007 +0200

[CPUFREQ] the overdue removal of X86_SPEEDSTEP_CENTRINO_ACPI

This patch contains the overdue removal of X86_SPEEDSTEP_CENTRINO_ACPI.

commit 905497c4b2e6715eebde97cbcb313354e14c2489

Author: Rafał Bilski <[email protected]>
Date:   Sun Jul 8 21:51:26 2007 +0200

[CPUFREQ] Longhaul - Option to disable ACPI C3 support

On some motherboards ACPI C3 is available, but it isn't causing frequency transition on VIA Nehemiah. Longhaul wasn't working at all earlier, but due to scaling_cur_speed returning true CPU frequency now, it looks like CPU is getting stuck at highest frequency since 2.6.21. I didn't find a reason. Halt is causing frequency transition.

Signature · 1 line
http://www.codemonkey.org.uk