Skip to contentSkip to conversation

NET_CLS_RSVP6 should depend on IPV6

PATCH In review Gabriel C 3 participants 4 messages Jul 14, 2007

Subsystems (3)
lore
Share & tools
lore

Gabriel C

author
#0 lore raw

PATCH 1/1 NET_CLS_RSVP6 should depend on IPV6

Hello,

cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends on IPV6.

---

net/sched/Kconfig | 3 ++-

 1 files changed, 2 insertions(+), 1 deletions(-)
net/sched/Kconfig +1 -0
index b466288..200976e 100644
@@ -299,6 +299,7 @@ config NET_CLS_RSVP
 
 config NET_CLS_RSVP6
        tristate "IPv6 Resource Reservation Protocol (RSVP6)"
+       depends on IPV6
        select NET_CLS
        ---help---
          The Resource Reservation Protocol (RSVP) permits end systems to
@@ -306,7 +307,7 @@ config NET_CLS_RSVP6
          is important for real time data such as streaming sound or video.
 
          Say Y here if you want to be able to classify outgoing packets

based
- on their RSVP requests and you are using the IPv6.
+ on their RSVP requests and you are using the IPv6 protocol.

To compile this code as a module, choose M here: the module will be called cls_rsvp6.

#1 lore raw
Quoted 2 lines · Gabriel C

cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends on IPV6.

I can't see any functional dependency on IPv6, what exactly are you refering to? People might want to use it on a bridge for example without having IPv6 running locally.

author
#2 lore raw
Quoted 12 lines · Patrick McHardy
Quoted 3 lines · Gabriel C

cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends on IPV6.

I can't see any functional dependency on IPv6, what exactly are you refering to? People might want to use it on a bridge for example without having IPv6 running locally.

I didn't knew it can be used with bridges , in this case just ignore the patch and sorry for the noise.

Regards,

Gabriel

maintainer
#3 lore raw
In reply to Patrick McHardy

From: Patrick McHardy <[email protected]>
Date: Sat, 14 Jul 2007 17:36:14 +0200

Quoted 8 lines
Quoted 2 lines · Gabriel C

cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends on IPV6.

I can't see any functional dependency on IPv6, what exactly are you refering to? People might want to use it on a bridge for example without having IPv6 running locally.

That's my feeling as well.