Skip to contentSkip to conversation

mm/Kconfig MEMORY_HOTPLUG typo ?

DISCUSSION Gabriel C 3 participants 4 messages Jul 20, 2007

lore
Share & tools
lore

Gabriel C

author
#0 lore raw

Hi,

I'm a bit confused about the following from mm/Kconfig:

..

config MEMORY_HOTPLUG

        bool "Allow for memory hot-add"
        depends on SPARSEMEM || X86_64_ACPI_NUMA
        depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG
        depends on (IA64 || X86 || PPC64 || SUPERH)

comment "Memory hotplug is currently incompatible with Software Suspend"

        depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND

...

That should be !SOFTWARE_SUSPEND no ?

Regards,

Gabriel C

#1 lore raw
Quoted 12 lines · Gabriel C

Hi,

I'm a bit confused about the following from mm/Kconfig:

..

config MEMORY_HOTPLUG

        bool "Allow for memory hot-add"
        depends on SPARSEMEM || X86_64_ACPI_NUMA
        depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG
        depends on (IA64 || X86 || PPC64 || SUPERH)
Quoted 7 lines

comment "Memory hotplug is currently incompatible with Software Suspend"

        depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND

...

That should be !SOFTWARE_SUSPEND no ?

No, it's correct.

You should see the comment instead of the option with SOFTWARE_SUSPEND=y.

Quoted 3 lines

Regards,

Gabriel C

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
In reply to Gabriel C
Quoted 10 lines · Gabriel C

I'm a bit confused about the following from mm/Kconfig:

..

config MEMORY_HOTPLUG

        bool "Allow for memory hot-add"
        depends on SPARSEMEM || X86_64_ACPI_NUMA
        depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG
        depends on (IA64 || X86 || PPC64 || SUPERH)

MEMORY_HOTPLUG is only supported if !SOFTWARE_SUSPEND

Quoted 8 lines

comment "Memory hotplug is currently incompatible with Software Suspend"

        depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND

...

That should be !SOFTWARE_SUSPEND no ?

However, we only give the comment that warns about the incompatability when SOFTWARE_SUSPEND is enabled, otherwise people won't see the option due to the unmet dependency.

author
#3 lore raw
Quoted 17 lines · Paul Mundt
Quoted 10 lines · Gabriel C

I'm a bit confused about the following from mm/Kconfig:

..

config MEMORY_HOTPLUG

        bool "Allow for memory hot-add"
        depends on SPARSEMEM || X86_64_ACPI_NUMA
        depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG
        depends on (IA64 || X86 || PPC64 || SUPERH)

MEMORY_HOTPLUG is only supported if !SOFTWARE_SUSPEND

Quoted 4 lines

comment "Memory hotplug is currently incompatible with Software Suspend"

        depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND
Quoted 8 lines
Quoted 4 lines

...

That should be !SOFTWARE_SUSPEND no ?

However, we only give the comment that warns about the incompatability when SOFTWARE_SUSPEND is enabled, otherwise people won't see the option due to the unmet dependency.

I think I got it :)

Thx for the clarification.

Gabriel