Skip to contentSkip to conversation

New wake ups from sky2

DISCUSSION Thomas Meyer 2 participants 2 messages Jul 21, 2007 – Jul 22, 2007 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20070720225038.7635da3f@oldman

#2 lore raw
Quoted 27 lines · Stephen Hemminger
Quoted 24 lines · Thomas Meyer

Today i did a git pull to be up to date again and i noticed in the powertop tool that i'll get this new entry

14,2% ( 9,1) <kernel core> : sky2_probe (sky2_idle)

with around 10 interrupts per second.

i think (i.e. i don't know and just guessing!) this commit is responsible for these wake ups:

git show eb35cf60e462491249166182e3e755d3d5d91a28

Author: Stephen Hemminger <[email protected]>
Date:   Tue Jun 13 17:17:31 2006 +0900

[PATCH] sky2: stop/start hardware idle timer on suspend/resume

The resume bug was caused not by an early interrupt but because the idle timeout was not being stopped on suspend. Also disable hardware IRQ's on suspend. Will need to revisit this with hotplug?

Quoted 9 lines
Quoted 3 lines

Any ideas?

Last version has idle timer enabled.
It is a tradeoff between device hanging due to lost interrupt or wasting power. You can make the timeout longer by setting idle_timeout module parameter larger, (or zero which will disable it).

Ok. But do you need to start the timer when no cable is plugged in, like in the case above?

mfg
thomas

#3 lore raw
Quoted 32 lines · On Sat, 21 Jul 2007 11:00:38 +0200 Thomas Meyer <[email protected]> wrote:
Quoted 31 lines · Stephen Hemminger
Quoted 27 lines · Thomas Meyer

Today i did a git pull to be up to date again and i noticed in the powertop tool that i'll get this new entry

14,2% ( 9,1) <kernel core> : sky2_probe (sky2_idle)

with around 10 interrupts per second.

i think (i.e. i don't know and just guessing!) this commit is responsible for these wake ups:

git show eb35cf60e462491249166182e3e755d3d5d91a28

Author: Stephen Hemminger <[email protected]>
Date:   Tue Jun 13 17:17:31 2006 +0900

[PATCH] sky2: stop/start hardware idle timer on suspend/resume

The resume bug was caused not by an early interrupt but because the idle timeout was not being stopped on suspend. Also disable hardware IRQ's on suspend. Will need to revisit this with hotplug?

Any ideas?

Quoted 7 lines
Quoted 5 lines

Last version has idle timer enabled.
It is a tradeoff between device hanging due to lost interrupt or wasting power. You can make the timeout longer by setting idle_timeout module parameter larger, (or zero which will disable it).

Ok. But do you need to start the timer when no cable is plugged in, like in the case above?

Probably not, because risk of missed PHY interrupt is miniscule.