drivers/scsi/sym53c416.c - address of 'sym53c416*' will always evaluate as 'true' , warnings

DISCUSSION Gabriel C 2 participants 3 messages Jul 22, 2007 SCSI

lore

Share & tools

lore

Gabriel C

author

2007-07-22 13:54 UTC #0 lore raw

Hi,

I got this warnings on current git with gcc 4.2.1 :

...

drivers/scsi/sym53c416.c: In function 'sym53c416_detect':
drivers/scsi/sym53c416.c:638: warning: the address of 'sym53c416' will always evaluate as 'true' drivers/scsi/sym53c416.c:644: warning: the address of 'sym53c416_1' will always evaluate as 'true' drivers/scsi/sym53c416.c:650: warning: the address of 'sym53c416_2' will always evaluate as 'true' drivers/scsi/sym53c416.c:656: warning: the address of 'sym53c416_3' will always evaluate as 'true'

...

Regards,

Gabriel C

Matthew Wilcox

2007-07-22 16:23 UTC #1 lore raw

Quoted 5 lines · Gabriel C

drivers/scsi/sym53c416.c: In function 'sym53c416_detect':
drivers/scsi/sym53c416.c:638: warning: the address of 'sym53c416' will always evaluate as 'true' drivers/scsi/sym53c416.c:644: warning: the address of 'sym53c416_1' will always evaluate as 'true' drivers/scsi/sym53c416.c:650: warning: the address of 'sym53c416_2' will always evaluate as 'true' drivers/scsi/sym53c416.c:656: warning: the address of 'sym53c416_3' will always evaluate as 'true'

These warnings certainly indicate a problem; I've looked through the driver and it's a bit of a mess. Do you have one of these cards? I can write and send you some patches to test on Monday or Tuesday, after I'm done with the advansys driver.

Signature · 3 lines

"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Gabriel C

author

2007-07-22 16:40 UTC #2 lore raw

Quoted 7 lines · Matthew Wilcox

Quoted 5 lines · Gabriel C
drivers/scsi/sym53c416.c: In function 'sym53c416_detect':
drivers/scsi/sym53c416.c:638: warning: the address of 'sym53c416' will always evaluate as 'true' drivers/scsi/sym53c416.c:644: warning: the address of 'sym53c416_1' will always evaluate as 'true' drivers/scsi/sym53c416.c:650: warning: the address of 'sym53c416_2' will always evaluate as 'true' drivers/scsi/sym53c416.c:656: warning: the address of 'sym53c416_3' will always evaluate as 'true'

Quoted 5 lines

These warnings certainly indicate a problem; I've looked through the driver and it's a bit of a mess. Do you have one of these cards? I can write and send you some patches to test on Monday or Tuesday, after I'm done with the advansys driver.

Sorry , I don't have these cards :/

Regards,

Gabriel