[2.6.22] Fix a potential NULL pointer dereference in mace_interrupt() in drivers/net/pcmcia/nmclan_cs.c

This patch fixes a potential null dereference bug where we dereference DEV before a null check. This patch simply moves the dereferencing after the null check.

---

--- a/drivers/net/pcmcia/nmclan_cs.c +++ b/drivers/net/pcmcia/nmclan_cs.c @@ -996,7 +996,7 @@
{
struct net_device *dev = (struct net_device *) dev_id; mace_private *lp = netdev_priv(dev);
- kio_addr_t ioaddr = dev->base_addr;
+ kio_addr_t ioaddr;
int status;
int IntrCnt = MACE_MAX_IR_ITERATIONS;

@@ -1006,6 +1006,8 @@

    return IRQ_NONE;

}

+ ioaddr = dev->base_addr;
+

  if (lp->tx_irq_disabled) {
    printk(
      (lp->tx_irq_disabled?

PLEASE PLEASE PLEASE fix your mailer.

None of your patches are apply-able via script or patch(1), which is how all Linux maintainers apply patches.

If you want to contribute to the kernel, you -must- figure out how to send patches via email.

Linux kernel development is done almost exclusively through email, so it is very important to get the details right.

Jeff

applied (git-am worked!)