Skip to contentSkip to conversation

fbcon: Fix typo and bogus logic in get_default_font

PATCH In review Antonino A. Daplas 2 participants 2 messages Jul 26, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/33 fbcon: Fix typo and bogus logic in get_default_font

Reported in: Bugzilla Bug 8727

Fix typo and bogus logic in get_default_font(). The bug results in get_default_font() returning a font that may not be displayed properly by a framebuffer driver.

---

 drivers/video/console/fonts.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/console/fonts.c +2 -2
index a6828d0..96979c3 100644
@@ -133,8 +133,8 @@ #endif
 	if ((yres < 400) == (f->height <= 8))
 	    c += 1000;
 
-	if (!(font_w & (1 << (f->width - 1))) ||
-	    !(font_w & (1 << (f->height - 1))))
+	if ((font_w & (1 << (f->width - 1))) &&
+	    (font_h & (1 << (f->height - 1))))
 	    c += 1000;
 
 	if (c > cc) {

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/

#1 lore raw

It looks like patches 1-6 (at least) are 2.6.23 material, but I think it'd be better if you were to work out which of these are for 2.6.23, please?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/