Skip to contentSkip to conversation

ps3: Fix no storage devices found

PATCH In review Geert Uytterhoeven 2 participants 2 messages Aug 14, 2007 5 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#5 lore raw

PATCH 1/1 ps3: Fix no storage devices found

In reply to a message not in the archive

Fix probing of PS3 storage devices: in the success case, we should set error' to zero, not result'.

Without this patch no storage devices are found.

---
This brown paper bag bug slipped in due to bad patch splitting. Please apply as soon as possible. Thanks!

 arch/powerpc/platforms/ps3/device-init.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/platforms/ps3/device-init.c +1 -1
@@ -372,7 +372,7 @@ static int ps3_storage_wait_for_device(c
 		    notify_event->dev_type == repo->dev_type) {
 			pr_debug("%s:%u: device ready: dev_id %u\n", __func__,
 				 __LINE__, repo->dev_id);
-			result = 0;
+			error = 0;
 			break;
 		}
 

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   [email protected]	
Internet: http://www.sony-europe.com/

Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619

Acked-by on v1 1/1
#6 lore raw
Quoted 9 lines · Geert Uytterhoeven

Fix probing of PS3 storage devices: in the success case, we should set error' to zero, not result'.

Without this patch no storage devices are found.

---
This brown paper bag bug slipped in due to bad patch splitting. Please apply as soon as possible. Thanks!

Looks good.