Skip to contentSkip to conversation

drivers/net/e1000e/netdev.c warning fix

PATCH In review Michal Piotrowski 2 participants 2 messages Aug 22, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Michal Piotrowski

author
#0 lore raw

PATCH 1/1 drivers/net/e1000e/netdev.c warning fix

Hi,

This patch fixes the following compilation warning

drivers/net/e1000e/netdev.c: In function ‘e1000_setup_rctl’:
drivers/net/e1000e/netdev.c:1963: warning: unused variable ‘pages’

Regards,
Michal

Signature · 26 lines
LOG
http://www.stardust.webpages.pl/log/

--- linux-mm-clean/drivers/net/e1000e/netdev.c	2007-08-22 12:20:31.000000000 +0200
+++ linux-work/drivers/net/e1000e/netdev.c	2007-08-22 14:44:58.000000000 +0200
@@ -1960,7 +1960,10 @@ static void e1000_setup_rctl(struct e100
 	struct e1000_hw *hw = &adapter->hw;
 	u32 rctl, rfctl;
 	u32 psrctl = 0;
+
+#ifndef CONFIG_E1000_DISABLE_PACKET_SPLIT
 	u32 pages = 0;
+#endif
 
 	/* Program MC offset vector base */
 	rctl = er32(RCTL);

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
#1 lore raw
Quoted 10 lines · Michal Piotrowski

Hi,

This patch fixes the following compilation warning

drivers/net/e1000e/netdev.c: In function ‘e1000_setup_rctl’:
drivers/net/e1000e/netdev.c:1963: warning: unused variable ‘pages’

Regards,
Michal

also exposes a symbol issue. I think I want to remove this #ifdef CONFIG_E1000_DISABLE_PACKET_SPLIT from this driver alltogether...

Auke

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/