Skip to contentSkip to conversation

bz 253921: GFS2: panic after can't parse mount arguments

PATCH In review Abhijith Das 2 participants 2 messages Aug 23, 2007 – Aug 24, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bz 253921: GFS2: panic after can't parse mount arguments

When you try to mount gfs2 with -o garbage, the mount fails and the gfs2 superblock is deallocated and becomes NULL. The vfs comes around later on and calls gfs2_kill_sb. At this point the hidden gfs2 superblock pointer (sb->s_fs_info) is NULL and dereferencing it through gfs2_meta_syncfs causes the panic. (the other function call to gfs2_delete_debugfs_file() succeeds because this function already checks for a NULL pointer)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bz253921.patch
Type: text/x-patch
Size: 438 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070823/a827bb8d/attachment.bin>

#1 lore raw

Hi,

Quoted 9 lines · Abhijith Das

When you try to mount gfs2 with -o garbage, the mount fails and the gfs2 superblock is deallocated and becomes NULL. The vfs comes around later on and calls gfs2_kill_sb. At this point the hidden gfs2 superblock pointer (sb->s_fs_info) is NULL and dereferencing it through gfs2_meta_syncfs causes the panic. (the other function call to gfs2_delete_debugfs_file() succeeds because this function already checks for a NULL pointer)

Now in the -nmw git tree, thanks,

Steve.