Skip to contentSkip to conversation

s3c2410fb: adds pixclock to s3c2410fb_display

PATCH In review Antonino A. Daplas 1 participant 1 message Aug 26, 2007

Subsystems (4)
Arm (32-bit) Arm sub-architectures Framebuffer layer Arm Samsung Exynos
lore
Share & tools
lore

Antonino A. Daplas

author
#0 lore raw

PATCH 8/20 s3c2410fb: adds pixclock to s3c2410fb_display

From: Krzysztof Helt <[email protected]>

This patch adds pixelclock field to the s3c2410fb_display structure and make use of it in the driver.

The Bast machine defined 9 modes but pixclock and margin values are defined only for the 640x480 modes so I removed other modes.

This patch also fixes wrong display type constant for the SMDK2440 board.

Signed-off-by Krzysztof Helt <[email protected]>
Signed-off-by Antonino Daplas <[email protected]>

---

 arch/arm/mach-s3c2410/mach-amlm5900.c |    1 
 arch/arm/mach-s3c2410/mach-bast.c     |  112 +--------------------------------
 arch/arm/mach-s3c2410/mach-h1940.c    |    1 
 arch/arm/mach-s3c2410/mach-qt2410.c   |    3 +
 arch/arm/mach-s3c2440/mach-rx3715.c   |    1 
 arch/arm/mach-s3c2440/mach-smdk2440.c |    3 +
 drivers/video/s3c2410fb.c             |   42 +++++-------
 include/asm-arm/arch-s3c2410/fb.h     |    1 
 8 files changed, 28 insertions(+), 136 deletions(-)
arch/arm/mach-s3c2410/mach-amlm5900.c +1 -0
index c475422..a86d68d 100644
@@ -174,6 +174,7 @@ static struct s3c2410fb_display __initda
 
 	.type		= S3C2410_LCDCON1_STN4,
 
+	.pixclock	= 680000, /* HCLK = 100MHz */
 	.xres		= 160,
 	.yres		= 160,
 	.bpp		= 4,
arch/arm/mach-s3c2410/mach-bast.c +3 -109

136 lines not on this page · raw message

arch/arm/mach-s3c2410/mach-h1940.c +1 -0
index 78dfc7d..8a50842 100644
@@ -145,6 +145,7 @@ static struct s3c2410fb_display h1940_lc
 	.type =		S3C2410_LCDCON1_TFT,
 	.width =	240,
 	.height =	320,
+	.pixclock =	260000,
 	.xres =		240,
 	.yres =		320,
 	.bpp =		16,
arch/arm/mach-s3c2410/mach-qt2410.c +3 -0
index ac94d56..612f624 100644
@@ -112,6 +112,7 @@ static struct s3c2410fb_display qt2410_l
 		.width		= 640,
 		.height		= 480,
 
+		.pixclock	= 40000, /* HCLK/4 */
 		.xres		= 640,
 		.yres		= 480,
 		.bpp		= 16,

@@ -137,6 +138,7 @@ static struct s3c2410fb_display qt2410_l
 		.type		= S3C2410_LCDCON1_TFT,
 		.width		= 480,
 		.height		= 640,
+		.pixclock	= 40000, /* HCLK/4 */
 		.xres		= 480,
 		.yres		= 640,
 		.bpp		= 16,

@@ -162,6 +164,7 @@ static struct s3c2410fb_display qt2410_l
 		.type		= S3C2410_LCDCON1_TFT,
 		.width		= 240,
 		.height		= 320,
+		.pixclock	= 100000, /* HCLK/10 */
 		.xres		= 240,
 		.yres		= 320,
 		.bpp		= 16,
arch/arm/mach-s3c2440/mach-rx3715.c +1 -0
index f26adea..408337f 100644
@@ -123,6 +123,7 @@ static struct s3c2410fb_display rx3715_l
 	.width		= 240,
 	.height		= 320,
 
+	.pixclock	= 260000,
 	.xres		= 240,
 	.yres		= 320,
 	.bpp		= 16,
arch/arm/mach-s3c2440/mach-smdk2440.c +2 -1
index 840a480..561e391 100644
@@ -115,11 +115,12 @@ static struct s3c2410fb_display smdk2440
 			  S3C2410_LCDCON5_PWREN |
 			  S3C2410_LCDCON5_HWSWP,
 
-	.type		= S3C2410_LCDCON1_TFT16BPP,
+	.type		= S3C2410_LCDCON1_TFT,
 
 	.width		= 240,
 	.height		= 320,
 
+	.pixclock	= 166667, /* HCLK 60 MHz, divisor 10 */
 	.xres		= 240,
 	.yres		= 320,
 	.bpp		= 16,
drivers/video/s3c2410fb.c +16 -26

70 lines not on this page · raw message

include/asm-arm/arch-s3c2410/fb.h +1 -0
index 6f022bd..9abe67b 100644
@@ -36,6 +36,7 @@ struct s3c2410fb_display {
 	unsigned short yres;
 	unsigned short bpp;
 
+	unsigned pixclock;		/* pixclock in picoseconds */
 	unsigned short left_margin;  /* value in pixels (TFT) or HCLKs (STN) */
 	unsigned short right_margin; /* value in pixels (TFT) or HCLKs (STN) */
 	unsigned short hsync_len;    /* value in pixels (TFT) or HCLKs (STN) */

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/