Skip to contentSkip to conversation

Fix double-free in tapdisk cleanup

PATCH New Ben Guthro 1 participant 1 message Aug 27, 2007

lore
Share & tools
lore

Ben Guthro

author
#0 lore raw

PATCH 1/1 Fix double-free in tapdisk cleanup

Fixed double-free() during normal tapdisk cleanup for quit process

tools/blktap/drivers/tapdisk.c +6 -3
diff -r 58aa2447f212 tools/blktap/drivers/tapdisk.c
@@ -849,6 +849,8 @@ int main(int argc, char *argv[])
 		exit(-1);
 	}
 
+	DPRINTF("running R: '%s' W: '%s'\n", argv[1], argv[2]);
+
 	while (run) 
         {
 		ret = 0;
@@ -914,12 +916,13 @@ int main(int argc, char *argv[])
 		s = ptr->s;
 
 		unmap_disk(s);
-		free(s->blkif);
-		free(s->ring_info);
-		free(s);
+
 		close(ptr->tap_fd);
 		ptr = ptr->next;
 	}
+
+	DPRINTF("done R: '%s' W: '%s'\n", argv[1], argv[2]);
+
 	closelog();
 
 	return 0;

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel