Removed compiler issue (invalid lvalue) - CPU PXA270
PATCH 1/1 Removed compiler issue (invalid lvalue) - CPU PXA270
Code is broken for PXA270 due to "invalid lvalue in assignment".
This patch fix it in pxa-regs.h
Signature · 9 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: 0005-Removed-compiler-issue-invalid-lvalue.txt Url: http://lists.denx.de/pipermail/u-boot/attachments/20070830/f9235461/attachment.txt
Wolfgang Denk
AppliedPATCH 1/1 Removed compiler issue (invalid lvalue) - CPU PXA270
Quoted 10 lines · In message <[email protected]> you wrote:
This is a multi-part message in MIME format. --------------030401040309070602030800
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bitCode is broken for PXA270 due to "invalid lvalue in assignment".
This patch fix it in
pxa-regs.hSigned-off-by Stefano Babic <[email protected]>
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Q: What do you get when you cross an ethernet with an income statement? A: A local area networth.
PATCH 1/1 Removed compiler issue (invalid lvalue) - CPU PXA270
In reply to stefano babicQuoted 7 lines · stefano babic <sbabic <at> denx.de> writes:
Code is broken for PXA270 due to "invalid lvalue in assignment".
This patch fix it in
pxa-regs.hSigned-off-by Stefano Babic <sbabic <at> denx.de>
This Patch makes wrong calculation!
The real bug can be fixed by using the old style with pointer / address (from the linux kernel)
#define GPLR(x) (*((((x) & 0x7f) < 96) ? &_GPLR(x) : &GPLR3))
or by fixing the calculation
#define GPLR(x) __REG2(0x40E00000, (((x) & 0x7f) < 96) ? ((x) & 0x60) >> 3 : 0x100)
Which is the preferred way?
Stefan
PATCH 1/1 Removed compiler issue (invalid lvalue) - CPU PXA270
Quoted 2 lines · Stefan Herbrechtsmeier
The real bug can be fixed by using the old style with pointer / address (from the linux kernel)
You are right and a patch was already sent to fix this problem, only at a wrong time and was not accepted (you find it in the list with the subject "Fix gcc issues in pxa-regs.h"). It contains the same solution as in Kernel. I forget to re-submit the patch, sorry.
Wolfgang has already confirmed to me that he will integrate this patch.
stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================