Remove unneeded pointer intf from speedtch_upload_firmware() in drivers/usb/atm/speedtch.c

PATCH New Micah Gruber 1 participant 1 message Sep 5, 2007

Subsystems (3)

USB ATM Alcatel speedtouch USB driver

lore

Share & tools

lore

Micah Gruber

author

2007-09-05 05:48 UTC #0 lore raw

PATCH 1/1 Remove unneeded pointer intf from speedtch_upload_firmware() in drivers/usb/atm/speedtch.c

This trivial patch removes the unneeded pointer intf returned from usb_ifnum_to_if(), which is never used. The check for NULL can be simply done by if (!usb_ifnum_to_if(usb_dev, 2)).

Signed-off-by Micah Gruber <[email protected]>

---

drivers/usb/atm/speedtch.c +1 -2

@@ -251,7 +251,6 @@
 {
 	unsigned char *buffer;
 	struct usbatm_data *usbatm = instance->usbatm;
-	struct usb_interface *intf;
 	struct usb_device *usb_dev = usbatm->usb_dev;
 	int actual_length;
 	int ret = 0;

@@ -265,7 +264,7 @@
 		goto out;
 	}
 
-	if (!(intf = usb_ifnum_to_if(usb_dev, 2))) {
+	if (!usb_ifnum_to_if(usb_dev, 2)) {
 		ret = -ENODEV;
 		usb_dbg(usbatm, "%s: interface not found!\n", __func__);
 		goto out_free;