Two identical entries for "rtc" in /proc/devices
# ls -li total 0 4026532007 -r--r--r-- 1 root root 0 Sep 6 18:18 nvram 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532056 -rw-r--r-- 1 root root 0 Sep 6 18:18 snd-page-alloc
kernel 2.6.22.6 on a Dell Precision 390:
# CONFIG_RTC is not set
# CONFIG_RTC_DEBUG is not setCONFIG_GEN_RTC=yCONFIG_GEN_RTC_X=yCONFIG_RTC_CLASS=yCONFIG_RTC_HCTOSYS=yCONFIG_RTC_HCTOSYS_DEVICE="rtc0"CONFIG_RTC_INTF_SYSFS=yCONFIG_RTC_INTF_PROC=yCONFIG_RTC_INTF_DEV=y
# CONFIG_RTC_INTF_DEV_UIE_EMUL is not setCONFIG_RTC_DRV_CMOS=mCONFIG_RTC_DRV_DS1307=mCONFIG_RTC_DRV_DS1553=mCONFIG_RTC_DRV_DS1672=mCONFIG_RTC_DRV_DS1742=m
# CONFIG_RTC_DRV_EP93XX is not setCONFIG_RTC_DRV_ISL1208=mCONFIG_RTC_DRV_MAX6900=m
# CONFIG_RTC_DRV_M48T86 is not setCONFIG_RTC_DRV_PCF8563=mCONFIG_RTC_DRV_PCF8583=mCONFIG_RTC_DRV_RS5C372=m
# CONFIG_RTC_DRV_SA1100 is not set
# CONFIG_RTC_DRV_TEST is not setCONFIG_RTC_DRV_X1205=mCONFIG_RTC_DRV_V3020=m
CONFIG_HPET_EMULATE_RTC=y
CONFIG_EFI_RTC=y
Quoted 6 lines · On Thu, 06 Sep 2007 18:23:22 -0400 Chuck Ebbert <[email protected]> wrote:
# ls -li total 0 4026532007 -r--r--r-- 1 root root 0 Sep 6 18:18 nvram 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532056 -rw-r--r-- 1 root root 0 Sep 6 18:18 snd-page-alloc
Next -mm has
procfs-detect-duplicate-names.patch
procfs-detect-duplicate-names-fix.patch
procfs-detect-duplicate-names-fix-fix-2.patch
which will at least tell us who the second offender is.
I have a vague memory that this is due to selecting two different types of rtc in config. Perhaps a Kconfig fix is needed, dunno.
Quoted 9 lines · On Thu, 06 Sep 2007 18:23:22 -0400 Chuck Ebbert <[email protected]> wrote:
Quoted 7 lines
# ls -li total 0 4026532007 -r--r--r-- 1 root root 0 Sep 6 18:18 nvram 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532056 -rw-r--r-- 1 root root 0 Sep 6 18:18 snd-page-alloc
Quoted 7 lines
Next -mm has
procfs-detect-duplicate-names.patch
procfs-detect-duplicate-names-fix.patch
procfs-detect-duplicate-names-fix-fix-2.patchwhich will at least tell us who the second offender is.
Semes pretty clear that this must be procfs itself... when a filesystem sees a name in a directory, it should refuse to make another file with the same name. And it should *never* reuse inode numbers...
Quoted 15 lines · On Sat, 15 Sep 2007 11:50:21 -0700 David Brownell <[email protected]> wrote:
Quoted 15 lines · On Thu, 06 Sep 2007 18:23:22 -0400 Chuck Ebbert <[email protected]> wrote:
Quoted 7 lines
# ls -li total 0 4026532007 -r--r--r-- 1 root root 0 Sep 6 18:18 nvram 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532056 -rw-r--r-- 1 root root 0 Sep 6 18:18 snd-page-allocNext -mm has
procfs-detect-duplicate-names.patch
procfs-detect-duplicate-names-fix.patch
procfs-detect-duplicate-names-fix-fix-2.patch
Quoted 7 lines
Quoted 1 line
which will at least tell us who the second offender is.
Semes pretty clear that this must be procfs itself... when a filesystem sees a name in a directory, it should refuse to make another file with the same name. And it should *never* reuse inode numbers...
procfs can reject the attempt to create the file, but the bottom line is that two different callsites are trying to create the same file. One of those callsites needs fixing?
Quoted 18 lines · Andrew Morton
Quoted 9 lines · On Sat, 15 Sep 2007 11:50:21 -0700 David Brownell <[email protected]> wrote:
Quoted 9 lines · On Thu, 06 Sep 2007 18:23:22 -0400 Chuck Ebbert <[email protected]> wrote:
Quoted 7 lines
# ls -li total 0 4026532007 -r--r--r-- 1 root root 0 Sep 6 18:18 nvram 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532067 -r--r--r-- 1 root root 0 Sep 6 18:18 rtc 4026532056 -rw-r--r-- 1 root root 0 Sep 6 18:18 snd-page-allocQuoted 6 lines
Quoted 1 line
...
Semes pretty clear that this must be procfs itself... when a filesystem sees a name in a directory, it should refuse to make another file with the same name. And it should *never* reuse inode numbers...
Quoted 5 lines
...
procfs can reject the attempt to create the file, but the bottom line is that two different callsites are trying to create the same file. One of those callsites needs fixing?
Both of those call sites have code to handle procfs rejecting the file creation; nothing to fix. And anyway, there's no way this is a *caller* bug!
The missing step seems to be that proc_register() doesn't bother to check whether there's already an entry for that file. Which is what the appended *UNTESTED* patch does (it compiles though).
- Dave
fs/proc/generic.c +13 -2
@@ -521,10 +521,11 @@ static const struct inode_operations pro .setattr = proc_notify_change, }; -static int proc_register (struct proc_dir_entry * dir,struct proc_dir_entry * dp) +static int proc_register (struct proc_dir_entry *dir,struct proc_dir_entry *dp) {unsigned int i; - +struct proc_dir_entry *de; + i =get_inode_number ();if (i ==0 )return -EAGAIN ;
@@ -547,6 +548,16 @@ static int proc_register(struct proc_dir }spin_lock (&proc_subdir_lock); + +for (de = dir->subdir; de ; de = de->next) { +if (de->namelen != dp->namelen) +continue ; +if (!memcmp (de->name, dp->name, de->namelen)) { +spin_unlock (&proc_subdir_lock); +return -EEXIST ; + } + } + dp->next = dir->subdir; dp->parent = dir; dir->subdir = dp;