Skip to contentSkip to conversation

reduce msr efer reloads on heavyweight vmexit

PATCH New Avi Kivity 1 participant 1 message Sep 16, 2007 KVM

lore
Share & tools
lore

Avi Kivity

author
#0 lore raw

PATCH 1/1 reduce msr efer reloads on heavyweight vmexit

Eddie, can you review the attached patch? It improves on your efer reload patch by avoiding a reload even if EFER.SCE is different in the guest and host, in some scenarios.

Signature · 1 line
error compiling committee.c: too many arguments to function
Quoted 1 line

From 6a59915f3720e3f33f1c9e81fd50e0f45699d035 Mon Sep 17 00:00:00 2001

From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/[email protected]>
Date: Wed, 29 Aug 2007 03:48:05 +0300
Subject: [PATCH] KVM: VMX: Further reduce efer reloads

KVM avoids reloading the efer msr when the difference between the guest and host values consist of the long mode bits (which are switched by hardware) and the NX bit (which is emulated by the KVM MMU).

This patch also allows KVM to ignore SCE (syscall enable) when the guest is running in 32-bit mode. This is because the syscall instruction is not available in 32-bit mode on Intel processors, so the SCE bit is effectively meaningless.

Signed-off-by Avi Kivity <avi-atKUWr5tajBWk0Htik3J/[email protected]>
---
 drivers/kvm/vmx.c |   43 ++++++++++++++++++++-----------------------
 1 files changed, 20 insertions(+), 23 deletions(-)
drivers/kvm/vmx.c +20 -23
index 07ec556..c20c736 100644
@@ -57,6 +57,7 @@ struct vcpu_vmx {
 		u16           fs_sel, gs_sel, ldt_sel;
 		int           gs_ldt_reload_needed;
 		int           fs_reload_needed;
+		int           guest_efer_loaded;
 	}host_state;
 
 };

@@ -74,8 +75,6 @@ static DEFINE_PER_CPU(struct vmcs *, current_vmcs);
 static struct page *vmx_io_bitmap_a;
 static struct page *vmx_io_bitmap_b;
 
-#define EFER_SAVE_RESTORE_BITS ((u64)EFER_SCE)
-
 static struct vmcs_config {
 	int size;
 	int order;

@@ -138,18 +137,6 @@ static void save_msrs(struct kvm_msr_entry *e, int n)
 		rdmsrl(e[i].index, e[i].data);
 }
 
-static inline u64 msr_efer_save_restore_bits(struct kvm_msr_entry msr)
-{
-	return (u64)msr.data & EFER_SAVE_RESTORE_BITS;
-}
-
-static inline int msr_efer_need_save_restore(struct vcpu_vmx *vmx)
-{
-	int efer_offset = vmx->msr_offset_efer;
-	return msr_efer_save_restore_bits(vmx->host_msrs[efer_offset]) !=
-		msr_efer_save_restore_bits(vmx->guest_msrs[efer_offset]);
-}
-
 static inline int is_page_fault(u32 intr_info)
 {
 	return (intr_info & (INTR_INFO_INTR_TYPE_MASK | INTR_INFO_VECTOR_MASK |

@@ -344,13 +331,24 @@ static void reload_tss(void)
 
 static void load_transition_efer(struct vcpu_vmx *vmx)
 {
-	u64 trans_efer;
 	int efer_offset = vmx->msr_offset_efer;
-
-	trans_efer = vmx->host_msrs[efer_offset].data;
-	trans_efer &= ~EFER_SAVE_RESTORE_BITS;
-	trans_efer |= msr_efer_save_restore_bits(vmx->guest_msrs[efer_offset]);
-	wrmsrl(MSR_EFER, trans_efer);
+	u64 host_efer = vmx->host_msrs[efer_offset].data;
+	u64 guest_efer = vmx->guest_msrs[efer_offset].data;
+	u64 ignore_bits;
+
+	/* NX is emulated; LMA and LME handled by hardware */
+	ignore_bits = EFER_NX | EFER_LMA | EFER_LME;
+	/* SCE is meaningless outside long mode */
+	if (!(guest_efer & EFER_LMA))
+		ignore_bits |= EFER_SCE;
+	vmx->host_state.guest_efer_loaded
+		= (guest_efer & ~ignore_bits) != (host_efer & ~ignore_bits);
+
+	if (!vmx->host_state.guest_efer_loaded)
+		return;
+	guest_efer &= ~ignore_bits;
+	guest_efer |= host_efer & ignore_bits;
+	wrmsrl(MSR_EFER, guest_efer);
 	vmx->vcpu.stat.efer_reload++;
 }
 

@@ -399,8 +397,7 @@ static void vmx_save_host_state(struct kvm_vcpu *vcpu)
 	}
 #endif
 	load_msrs(vmx->guest_msrs, vmx->save_nmsrs);
-	if (msr_efer_need_save_restore(vmx))
-		load_transition_efer(vmx);
+	load_transition_efer(vmx);
 }
 
 static void vmx_load_host_state(struct vcpu_vmx *vmx)

@@ -429,7 +426,7 @@ static void vmx_load_host_state(struct vcpu_vmx *vmx)
 	reload_tss();
 	save_msrs(vmx->guest_msrs, vmx->save_nmsrs);
 	load_msrs(vmx->host_msrs, vmx->save_nmsrs);
-	if (msr_efer_need_save_restore(vmx))
+	if (vmx->host_state.guest_efer_loaded)
 		load_msrs(vmx->host_msrs + vmx->msr_offset_efer, 1);
 }
Signature · 1 line
1.5.3

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel