Skip to contentSkip to conversation

2.6.23-rc6-mm1 powerpc - kgdb is broken

DISCUSSION Kamalesh Babulal 6 participants 9 messages Sep 19, 2007 – Sep 28, 2007 Library code

lore
Share & tools
lore
#0 lore raw

Hi Andrew,

The kgdb seems to be broken on the powerpc, while compiling with allyesconfig.

  LD [M]  drivers/isdn/hysdn/hysdn.o
  CC [M]  drivers/net/kgdboe.o
  CC [M]  drivers/scsi/scsi_wait_scan.o

In file included from include/linux/kgdb.h:22,
from drivers/net/kgdboe.c:28:
include/asm/kgdb.h:34: error: 'debugger' redeclared as different kind of symbol include/asm/system.h:85: error: previous definition of 'debugger' was here include/asm/kgdb.h:35: error: 'debugger_bpt' redeclared as different kind of symbol include/asm/system.h:87: error: previous definition of 'debugger_bpt' was here include/asm/kgdb.h:36: error: 'debugger_sstep' redeclared as different kind of symbol include/asm/system.h:88: error: previous definition of 'debugger_sstep' was here include/asm/kgdb.h:37: error: 'debugger_iabr_match' redeclared as different kind of symbol include/asm/system.h:89: error: previous definition of 'debugger_iabr_match' was here include/asm/kgdb.h:38: error: 'debugger_dabr_match' redeclared as different kind of symbol include/asm/system.h:90: error: previous definition of 'debugger_dabr_match' was here include/asm/kgdb.h:39: error: 'debugger_fault_handler' redeclared as different kind of symbol include/asm/system.h:91: error: previous definition of 'debugger_fault_handler' was here In file included from drivers/net/kgdboe.c:28:
include/linux/kgdb.h:69: error: 'BREAK_INSTR_SIZE' undeclared here (not in a function) make[3]: *** [drivers/net/kgdboe.o] Error 1
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [modules] Error 2

Signature · 4 lines
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
#1 lore raw

I am not exactly sure how to fix this...

Another git tree is overriding the patch to include/asm-powerpc/kgdb.h
in the -mm tree. The patches as I provide them against 2.6.23-rc6 for
KGDB work correctly for ppc/powerpc in 32 and 64 bit modes and compile correctly.

At issue is that someone merged a bogus copy of asm-ppc/kgdb.h from the git tree in -mm that is called: git-powerpc.patch.

Jason.

Quoted 31 lines · Kamalesh Babulal

Hi Andrew,

The kgdb seems to be broken on the powerpc, while compiling with allyesconfig.

  LD [M]  drivers/isdn/hysdn/hysdn.o
  CC [M]  drivers/net/kgdboe.o
  CC [M]  drivers/scsi/scsi_wait_scan.o

In file included from include/linux/kgdb.h:22,
from drivers/net/kgdboe.c:28:
include/asm/kgdb.h:34: error: 'debugger' redeclared as different kind of symbol include/asm/system.h:85: error: previous definition of 'debugger' was here include/asm/kgdb.h:35: error: 'debugger_bpt' redeclared as different kind of symbol include/asm/system.h:87: error: previous definition of 'debugger_bpt' was here include/asm/kgdb.h:36: error: 'debugger_sstep' redeclared as different kind of symbol include/asm/system.h:88: error: previous definition of 'debugger_sstep' was here include/asm/kgdb.h:37: error: 'debugger_iabr_match' redeclared as different kind of symbol include/asm/system.h:89: error: previous definition of 'debugger_iabr_match' was here include/asm/kgdb.h:38: error: 'debugger_dabr_match' redeclared as different kind of symbol include/asm/system.h:90: error: previous definition of 'debugger_dabr_match' was here include/asm/kgdb.h:39: error: 'debugger_fault_handler' redeclared as different kind of symbol include/asm/system.h:91: error: previous definition of 'debugger_fault_handler' was here In file included from drivers/net/kgdboe.c:28:
include/linux/kgdb.h:69: error: 'BREAK_INSTR_SIZE' undeclared here (not in a function) make[3]: *** [drivers/net/kgdboe.o] Error 1
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [modules] Error 2

maintainer
#2 lore raw
Quoted 9 lines · On Wed, 19 Sep 2007 13:53:01 -0500 Jason Wessel <[email protected]>…

I am not exactly sure how to fix this...

Another git tree is overriding the patch to include/asm-powerpc/kgdb.h
in the -mm tree. The patches as I provide them against 2.6.23-rc6 for
KGDB work correctly for ppc/powerpc in 32 and 64 bit modes and compile correctly.

At issue is that someone merged a bogus copy of asm-ppc/kgdb.h from the git tree in -mm that is called: git-powerpc.patch.

Yeah, this was pointed out and largely ignored.

I'm afraid you'll have to wait until that powerpc stuff hits mainline and then fix it all up.

#3 lore raw
Quoted 9 lines · Andrew Morton
Quoted 7 lines · On Wed, 19 Sep 2007 13:53:01 -0500 Jason Wessel <[email protected]>…

I am not exactly sure how to fix this...

Another git tree is overriding the patch to include/asm-powerpc/kgdb.h
in the -mm tree. The patches as I provide them against 2.6.23-rc6 for
KGDB work correctly for ppc/powerpc in 32 and 64 bit modes and compile correctly.

Quoted 7 lines
Quoted 2 lines

At issue is that someone merged a bogus copy of asm-ppc/kgdb.h from the git tree in -mm that is called: git-powerpc.patch.

Yeah, this was pointed out and largely ignored.

I'm afraid you'll have to wait until that powerpc stuff hits mainline and then fix it all up.

I could remove all the kgdb support from arch/powerpc as a first step, if that would make it easier to pull in the new stuff...

Paul.

maintainer
#4 lore raw
Quoted 14 lines · On Thu, 20 Sep 2007 15:23:19 +1000 Paul Mackerras <[email protected]> wrote:
Quoted 12 lines · Andrew Morton
Quoted 9 lines · On Wed, 19 Sep 2007 13:53:01 -0500 Jason Wessel <[email protected]>…

I am not exactly sure how to fix this...

Another git tree is overriding the patch to include/asm-powerpc/kgdb.h
in the -mm tree. The patches as I provide them against 2.6.23-rc6 for
KGDB work correctly for ppc/powerpc in 32 and 64 bit modes and compile correctly.

At issue is that someone merged a bogus copy of asm-ppc/kgdb.h from the git tree in -mm that is called: git-powerpc.patch.

Quoted 8 lines
Quoted 4 lines

Yeah, this was pointed out and largely ignored.

I'm afraid you'll have to wait until that powerpc stuff hits mainline and then fix it all up.

I could remove all the kgdb support from arch/powerpc as a first step, if that would make it easier to pull in the new stuff...

I don't know if/when the new stuff will be merged - it's missed 2.6.24.

It might be better to proceed as you intended. Presumably it won't be too hard to hack things back into shape.

#5 lore raw
In reply to Paul Mackerras
Quoted 2 lines · Paul Mackerras

I could remove all the kgdb support from arch/powerpc as a first step, if that would make it easier to pull in the new stuff...

Given that the existing powerpc kgdb bits didn't seem to work at all when I tried them that seems like a perfectly fine thing to do.

#6 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Paul Mackerras

I could remove all the kgdb support from arch/powerpc as a first step, if that would make it easier to pull in the new stuff...

Quoted 9 lines

Given that the existing powerpc kgdb bits didn't seem to work at all when I tried them that seems like a perfectly fine thing to do.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Hi Paul,

The kgdb is also broken with 2.6.23-rc8-mm2 on the powerpc . The below patch disables the kgdb from getting compiled over powerpc platform.

---

lib/~Kconfig.kgdb 2007-09-28 23:48:33.000000000 +0530 renamed from lib/Kconfig.kgdb 2007-09-28 06:33:37.000000000 +0530 +1 -1
@@ -14,7 +14,7 @@ config KGDB
        bool "KGDB: kernel debugging with remote gdb"
        select WANT_EXTRA_DEBUG_INFORMATION
        select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
-       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
+       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || !PPC)
        help
          If you say Y here, it will be possible to remotely debug the
          kernel using gdb.  Documentation of kernel debugger is available
Signature · 4 lines
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
#7 lore raw
Quoted 10 lines · Kamalesh Babulal

The kgdb is also broken with 2.6.23-rc8-mm2 on the powerpc . The below patch disables the kgdb from getting compiled over powerpc platform.

---

lib/~Kconfig.kgdb 2007-09-28 23:48:33.000000000 +0530 config KGDB · line 17

Quoted 5 lines
lib/~Kconfig.kgdb 2007-09-28 23:48:33.000000000 +0530 renamed from lib/Kconfig.kgdb 2007-09-28 06:33:37.000000000 +0530 +1 -1
@@ -14,7 +14,7 @@ config KGDB
        bool "KGDB: kernel debugging with remote gdb"
        select WANT_EXTRA_DEBUG_INFORMATION
        select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
-       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
+       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || !PPC)

This enables the KGDB config for _ALL_ platforms except powerpc.

Just remove PPC completely.

tglx

#8 lore raw

Re: 2.6.23-rc6-mm1 powerpc - kgdb is broken [Resending PATCH]

Quoted 21 lines · Thomas Gleixner
Quoted 10 lines · Kamalesh Babulal

The kgdb is also broken with 2.6.23-rc8-mm2 on the powerpc . The below patch disables the kgdb from getting compiled over powerpc platform.

---

lib/~Kconfig.kgdb 2007-09-28 23:48:33.000000000 +0530 config KGDB · line 18

Quoted 6 lines
lib/~Kconfig.kgdb 2007-09-28 23:48:33.000000000 +0530 renamed from lib/Kconfig.kgdb 2007-09-28 06:33:37.000000000 +0530 +1 -1
@@ -14,7 +14,7 @@ config KGDB
        bool "KGDB: kernel debugging with remote gdb"
        select WANT_EXTRA_DEBUG_INFORMATION
        select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
-       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
+       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || !PPC)
 

This enables the KGDB config for _ALL_ platforms except powerpc.

Quoted 4 lines

Just remove PPC completely.

tglx

Thanks thomas for the suggestion, resending the patch.

---

lib/~Kconfig.kgdb 2007-09-28 17:51:43.000000000 +0530 renamed from lib/Kconfig.kgdb 2007-09-28 17:46:55.000000000 +0530 +1 -1
@@ -14,7 +14,7 @@ config KGDB
        bool "KGDB: kernel debugging with remote gdb"
        select WANT_EXTRA_DEBUG_INFORMATION
        select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
-       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64 || PPC)
+       depends on DEBUG_KERNEL && (ARM || X86 || MIPS || (SUPERH && !SUPERH64) || IA64)
        help
          If you say Y here, it will be possible to remotely debug the
          kernel using gdb.  Documentation of kernel debugger is available
Signature · 4 lines
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.