Skip to contentSkip to conversation

Add --without-$subsystem support in toplevel configure/Makefile

PATCH New Fabio Massimo Di Nitto 2 participants 4 messages Sep 20, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add --without-$subsystem support in toplevel configure/Makefile

Hi guys,

the patch in attachment allows to disable the build/install targets for each specific subsystem in the tree.

thanks also to Joel Becker for a bunch of filter-out hints.

Please apply or ACK and I will apply.
Fabio

Signature · 5 lines
I'm going to make him an offer he can't refuse.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: support-without.diff
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070920/0ed78834/attachment.ksh>
#1 lore raw

PATCH 1/1 Add --without-$subsystem support in toplevel configure/Makefile

Quoted 4 lines · Fabio Massimo Di Nitto

the patch in attachment allows to disable the build/install targets for each specific subsystem in the tree.

thanks also to Joel Becker for a bunch of filter-out hints.

I'd like to see $USERLAND and $SUBDIRS made one variable. You
shouldn't need individual targets for each binary, etc. But perhaps that's a later pass.

Joel

Signature · 10 lines
"Gone to plant a weeping willow
 On the bank's green edge it will roll, roll, roll.
 Sing a lulaby beside the waters.
 Lovers come and go, the river roll, roll, rolls."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
#2 lore raw

PATCH 1/1 Add --without-$subsystem support in toplevel configure/Makefile

Quoted 7 lines · Joel Becker
Quoted 4 lines · Fabio Massimo Di Nitto

the patch in attachment allows to disable the build/install targets for each specific subsystem in the tree.

thanks also to Joel Becker for a bunch of filter-out hints.

I'd like to see $USERLAND and $SUBDIRS made one variable.

This can be done.

Quoted 3 lines

You
shouldn't need individual targets for each binary, etc. But perhaps that's a later pass.

I keep them separated because I can express dependencies (not all subsystems need all subsystems) and it let make -j work (something that was not working with the old style makefiles).

Fabio

Signature · 1 line
I'm going to make him an offer he can't refuse.
#3 lore raw

PATCH 1/1 Add --without-$subsystem support in toplevel configure/Makefile

Quoted 8 lines · Fabio Massimo Di Nitto
Quoted 3 lines · Joel Becker

You
shouldn't need individual targets for each binary, etc. But perhaps that's a later pass.

I keep them separated because I can express dependencies (not all subsystems need all subsystems) and it let make -j work (something that was not working with the old style makefiles).

Try this. The only tricky part is the patsubst converting cman-lib to cman/lib.

USERLAND = cman-lib ccs cman dlm group fence gfs gfs2 gnbd rgmanager
all: $(USERLAND)

$(USERLAND):

	[ -n "${without_$@}" || ${MAKE} -C $(patsubst -,/,$@) all

cman-lib:
ccs: cman-lib
cman: ccs
dlm:
group: ccs dlm
fence: group dlm
gfs:
gfs2:
gnbd: cman-lib
rgmanager: ccs dlm

Signature · 9 lines
Life's Little Instruction Book #30

	"Never buy a house without a fireplace."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127