Skip to contentSkip to conversation

: module fails to load because it can't register ac97 bus

ALSA - driver 0001334 [email protected] 1 participant 1 message Aug 15, 2005

lore
Share & tools
lore
#0 lore raw

A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1334>
======================================================================
Reported By: bdijkstra
Assigned To:
======================================================================

Project:                    ALSA - driver
Issue ID:                   1334
Category:                   PCI - cs46xx
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Distribution:               SuSE Linux
Kernel Version:             2.6.13-rc5-git3-3-default
======================================================================
Date Submitted:             08-14-2005 00:13 CEST
Last Modified:              08-15-2005 23:11 CEST

======================================================================
Summary: module fails to load because it can't register ac97
bus
Description:
The Hercules GameTheater XP card has two codecs of the same type (CS4294). The cs46xx driver tries to register these two codecs with the same name with the ac97 bus which then fails.
I have attached the message log of a module load which shows the problem.

======================================================================

----------------------------------------------------------------------
tiwai - 08-15-05 19:55
----------------------------------------------------------------------
The changes look OK to me.
Could you make a patch to the CVS version including both changes?

Thanks.

----------------------------------------------------------------------
bdijkstra - 08-15-05 23:11
----------------------------------------------------------------------
This is a patch against most recent cvs version of ac97_codec.c (1.194) --

[PATCH] make ac97 codec device name unique

--- sound/pci/ac97/ac97_codec.c.org 2005-08-15 23:04:35.000000000
+0200
+++ sound/pci/ac97/ac97_codec.c 2005-08-15 23:03:50.000000000 +0200 @@ -1829,7 +1829,7 @@

        ac97->dev.parent = ac97->bus->card->dev;
        ac97->dev.platform_data = ac97;
        ac97->dev.release = ac97_device_release;
-       strncpy(ac97->dev.bus_id, snd_ac97_get_short_name(ac97),
BUS_ID_SIZE);
+       snprintf(ac97->dev.bus_id, BUS_ID_SIZE, "card%d-%d",
ac97->bus->card->number, ac97->num);
        if ((err = device_register(&ac97->dev)) < 0) {
                snd_printk(KERN_ERR "Can't register ac97 bus\n");
                ac97->dev.bus = NULL;

Issue History
Date Modified Username Field Change
======================================================================

08-14-05 00:13 bdijkstra      New Issue                                    
08-14-05 00:13 bdijkstra      File Added: cs46xx-error.log                    
08-14-05 00:13 bdijkstra      Distribution              => SuSE Linux      
08-14-05 00:13 bdijkstra      Kernel Version            =>
2.6.13-rc5-git3-3-default
08-14-05 00:21 bdijkstra      Note Added: 0005812                          
08-14-05 14:19 bdijkstra      Note Added: 0005815                          
08-15-05 19:55 tiwai          Note Added: 0005820                          
08-15-05 23:11 bdijkstra      Note Added: 0005823                          

======================================================================

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf