Skip to contentSkip to conversation

mmc: at91_mci: cleanup: use MCI_ERRORS

PATCH Applied Nicolas Ferre 2 participants 2 messages Oct 17, 2007

Subsystems (2)
MMC, SD and SDIO Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Nicolas Ferre

author
#0 lore raw

PATCH 1/1 mmc: at91_mci: cleanup: use MCI_ERRORS

From: Andrew Victor <[email protected]>

A small MMC driver cleanup.

Use the defined AT91_MCI_ERRORS in at91_mci_completed_command() instead of specifying all the error bits individually.

Signed-off-by Andrew Victor <[email protected]>
Signed-off-by Nicolas Ferre <[email protected]>

---

drivers/mmc/host/at91_mci.c +0 -0
Index: linux-2.6-snapshot/drivers/mmc/host/at91_mci.c
===================================================================
@@ -581,9 +581,7 @@

	pr_debug("Status = %08X [%08X %08X %08X %08X]\n",
		 status, cmd->resp[0], cmd->resp[1], cmd->resp[2], cmd->resp[3]);

- if (status & (AT91_MCI_RINDE | AT91_MCI_RDIRE | AT91_MCI_RCRCE |
- AT91_MCI_RENDE | AT91_MCI_RTOE | AT91_MCI_DCRCE |
- AT91_MCI_DTOE | AT91_MCI_OVRE | AT91_MCI_UNRE)) {

+	if (status & AT91_MCI_ERRORS) {
		if ((status & AT91_MCI_RCRCE) && !(mmc_resp_type(cmd) & MMC_RSP_CRC)) {
			cmd->error = 0;
		}