Skip to contentSkip to conversation

Fixing the warning in cgroup.c

PATCH In review Kamalesh Babulal 3 participants 3 messages Oct 21, 2007 – Oct 24, 2007

lore
Share & tools
lore

Kamalesh Babulal

author
#0 lore raw

PATCH 1/1 Fixing the warning in cgroup.c

Hi,

Removing the unused variable root.

kernel/cgroup.c: In function ‘proc_cgroupstats_show’:
kernel/cgroup.c:2405: warning: unused variable ‘root’

Signed-off-by Kamalesh Babulal <[email protected]>
kernel/cgroup.c 2007-10-21 22:24:13.000000000 +0530 renamed from kernel/cgroup.c 2007-10-21 08:49:15.000000000 +0530 +0 -1
Index: linux-git/kernel/cgroup.c
===================================================================
@@ -2402,7 +2402,6 @@ struct file_operations proc_cgroup_opera
 static int proc_cgroupstats_show(struct seq_file *m, void *v)
 {
        int i;
-       struct cgroupfs_root *root;
 
        seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\n");
        mutex_lock(&cgroup_mutex);
Signature · 4 lines
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
Acked-by on v1 1/1
#1 lore raw
Quoted 16 lines · Kamalesh Babulal

Hi,

Removing the unused variable root.

kernel/cgroup.c: In function ‘proc_cgroupstats_show’:
kernel/cgroup.c:2405: warning: unused variable ‘root’

Signed-off-by Kamalesh Babulal <[email protected]>

Index: linux-git/kernel/cgroup.c
===================================================================

kernel/cgroup.c 2007-10-21 22:24:13.000000000 +0530 struct file_operations proc_cgroup_opera · line 2407

Quoted 7 lines
kernel/cgroup.c 2007-10-21 22:24:13.000000000 +0530 renamed from kernel/cgroup.c 2007-10-21 08:49:15.000000000 +0530 +0 -1
@@ -2402,7 +2402,6 @@ struct file_operations proc_cgroup_opera
 static int proc_cgroupstats_show(struct seq_file *m, void *v)
 {
        int i;
-       struct cgroupfs_root *root;
 
        seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\n");
        mutex_lock(&cgroup_mutex);

Looks good to me!

Acked-by Balbir Singh <[email protected]>
Signature · 4 lines
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
#2 lore raw
In reply to Kamalesh Babulal
Quoted 4 lines · On Sun, 21 Oct 2007 23:00:20 +0530 Kamalesh Babulal…

Removing the unused variable root.

kernel/cgroup.c: In function ‘proc_cgroupstats_show’:
kernel/cgroup.c:2405: warning: unused variable ‘root’

ERROR: Invalid UTF-8
#3:
kernel/cgroup.c: In function ‘proc_cgroupstats_show’:

ERROR: Invalid UTF-8
#4:
kernel/cgroup.c:2405: warning: unused variable ‘root’

total: 2 errors, 0 warnings, 7 lines checked
Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please use LANG=C so gcc doesn't do this.

Quoted 7 lines
Signed-off-by Kamalesh Babulal <[email protected]>

Index: linux-git/kernel/cgroup.c
===================================================================

kernel/cgroup.c 2007-10-21 22:24:13.000000000 +0530 struct file_operations proc_cgroup_opera · line 2407

Quoted 7 lines
kernel/cgroup.c 2007-10-21 22:24:13.000000000 +0530 renamed from kernel/cgroup.c 2007-10-21 08:49:15.000000000 +0530 +0 -1
@@ -2402,7 +2402,6 @@ struct file_operations proc_cgroup_opera
 static int proc_cgroupstats_show(struct seq_file *m, void *v)
 {
        int i;
-       struct cgroupfs_root *root;
 
        seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\n");
        mutex_lock(&cgroup_mutex);

your email client is converting tabs to spaces.