Skip to contentSkip to conversation

2.6.24-rc1-git8 build fails drivers/pci/probe.c

BUILD-FAILURE Kamalesh Babulal 2 participants 2 messages Oct 31, 2007 – Nov 1, 2007

lore
Share & tools
lore
#0 lore raw

Hi,

The 2.6.24-rc-git8 build fails with build error

CC drivers/pci/probe.o
drivers/pci/probe.c: In function 'pci_create_legacy_files':
drivers/pci/probe.c:56: error: implicit declaration of function 'class_device_create_bin_file' drivers/pci/probe.c: In function 'pci_remove_legacy_files':
drivers/pci/probe.c:71: error: implicit declaration of function 'class_device_remove_bin_file' make[2]: *** [drivers/pci/probe.o] Error 1
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2

This is caused by the commit fcd239d3d5575e5cc63aab5c33cf6dc66904f6d6 (Driver core: remove class_device_*_bin_file). These functions are still being used by drivers/pci/probe.c.

Signature · 4 lines
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
#1 lore raw
Quoted 13 lines · Kamalesh Babulal

Hi,

The 2.6.24-rc-git8 build fails with build error

CC drivers/pci/probe.o
drivers/pci/probe.c: In function 'pci_create_legacy_files':
drivers/pci/probe.c:56: error: implicit declaration of function 'class_device_create_bin_file' drivers/pci/probe.c: In function 'pci_remove_legacy_files':
drivers/pci/probe.c:71: error: implicit declaration of function 'class_device_remove_bin_file' make[2]: *** [drivers/pci/probe.o] Error 1
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2

Quoted 2 lines

This is caused by the commit fcd239d3d5575e5cc63aab5c33cf6dc66904f6d6 (Driver core: remove class_device_*_bin_file). These functions are still being used by drivers/pci/probe.c.

Thanks for the report, Linus's tree now has a fix for this oversight on my behalf.

greg k-h